public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 4/4] signal: Only handle on NSIG signals on signal functions (BZ #25657)
Date: Tue, 21 Apr 2020 16:07:14 +0200	[thread overview]
Message-ID: <87ftcxq6el.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <94cfdaa9-583e-dc6b-89dd-436051a0d2bb@linaro.org> (Adhemerval Zanella's message of "Tue, 21 Apr 2020 11:02:57 -0300")

* Adhemerval Zanella:

> On 21/04/2020 10:47, Florian Weimer wrote:
>> * Adhemerval Zanella:
>> 
>>> On 21/04/2020 10:14, Florian Weimer wrote:
>>> Only handle __NSIG_WORDS on linux sigsetopts.h instead of _SIGSET_NWORDS
>>> when manipulating sigset_t masks.
>> 
>> Hmm.  __NSIG_WORDS is defined like this:
>> 
>>> +# define __NSIG_WORDS (_NSIG / (8 * sizeof (unsigned long int )))
>> 
>> This gives us two words for _NSIG == 65.  Is this correct?
>
> Two words (32-bits) for all 64-bit architectures,

sizeof (unsigned long int) is 8 on 64-bit.  65 / (8 * 8) is 1.

I assume that for _NSIG == 65, the signal numbers from 0 to 64 are all
valid and can be manipulated using sigaddset etc.  This suggests to me
that we need three 32-bit longs and two 64-bit longs.

Sorry, maybe I'm confused, I'm not feeling too well this week.

  reply	other threads:[~2020-04-21 14:07 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13 19:48 [PATCH v2 1/4] nptl: Move pthread_sigmask implementation to libc Adhemerval Zanella
2020-03-13 19:48 ` [PATCH 2/4] ia64: Remove sigprocmask/sigblock objects from libpthread Adhemerval Zanella
2020-04-17 13:25   ` Adhemerval Zanella
2020-04-21 11:56   ` Florian Weimer
2020-04-21 12:06     ` Adhemerval Zanella
2020-03-13 19:48 ` [PATCH v2 3/4] linux: Use pthread_sigmask on sigprocmask Adhemerval Zanella
2020-04-17 13:25   ` Adhemerval Zanella
2020-04-21 12:01   ` Florian Weimer
2020-04-21 12:30     ` Adhemerval Zanella
2020-04-21 12:35       ` Florian Weimer
2020-04-21 13:01         ` Adhemerval Zanella
2020-03-13 19:48 ` [PATCH 4/4] signal: Only handle on NSIG signals on signal functions (BZ #25657) Adhemerval Zanella
2020-04-17 13:25   ` Adhemerval Zanella
2020-04-21 12:53   ` Florian Weimer
2020-04-21 13:11     ` Adhemerval Zanella
2020-04-21 13:14       ` Florian Weimer
2020-04-21 13:29         ` Adhemerval Zanella
2020-04-21 13:47           ` Florian Weimer
2020-04-21 14:02             ` Adhemerval Zanella
2020-04-21 14:07               ` Florian Weimer [this message]
2020-04-21 14:10                 ` Adhemerval Zanella
2020-04-21 14:35                   ` Florian Weimer
2020-04-21 14:36                     ` Adhemerval Zanella
2020-04-21 15:05                   ` Andreas Schwab
2020-04-21 17:28                     ` Florian Weimer
2020-04-21 17:49                       ` Adhemerval Zanella
2020-04-21 18:40                         ` Andreas Schwab
2020-04-21 19:00                           ` Adhemerval Zanella
2020-04-21 21:14                             ` Andreas Schwab
2020-04-22  8:32                               ` Florian Weimer
2020-04-22 11:34                                 ` Adhemerval Zanella
2020-04-17 13:25 ` [PATCH v2 1/4] nptl: Move pthread_sigmask implementation to libc Adhemerval Zanella
2020-04-21 11:50 ` Florian Weimer
2020-04-21 14:06   ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftcxq6el.fsf@mid.deneb.enyo.de \
    --to=fw@deneb.enyo.de \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).