public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Matthew Malcomson <Matthew.Malcomson@arm.com>
Cc: "libc-alpha\@sourceware.org" <libc-alpha@sourceware.org>,
	 nd <nd@arm.com>
Subject: Re: [Patch] [Makefile] Exit if provided an incorrect argument
Date: Mon, 04 Feb 2019 12:09:00 -0000	[thread overview]
Message-ID: <87ftt3sqk8.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <beab92e4-fcc6-5a79-03e2-082131fd3c96@arm.com> (Matthew Malcomson's message of "Tue, 15 Jan 2019 10:33:16 +0000")

* Matthew Malcomson:

> On 15/01/19 10:03, Florian Weimer wrote:
>> * Matthew Malcomson:
>>
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -148,6 +148,7 @@ while test $$# -gt 0 ; do
>>>         ;;
>>>       --*)
>>>         usage
>>> +      exit 1
>>>         ;;
>>>       *)
>>>         break
>> I think you should add the exit to the usage function.
>>
>> Thanks,
>> Florian
>
> Makes sense -- thanks!
> Fixed patch attached.

Thanks, pushed.

Florian

      reply	other threads:[~2019-02-04 12:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 15:16 Matthew Malcomson
2019-01-15 10:01 ` Matthew Malcomson
2019-01-15 10:04 ` Florian Weimer
2019-01-15 10:33   ` Matthew Malcomson
2019-02-04 12:09     ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftt3sqk8.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=Matthew.Malcomson@arm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).