From: Florian Weimer <fweimer@redhat.com>
To: DJ Delorie <dj@redhat.com>
Cc: "Carlos O'Donell" <carlos@redhat.com>,
alx@kernel.org, libc-alpha@sourceware.org
Subject: Re: [patch v4] manual: add syscall list
Date: Wed, 22 May 2024 23:00:55 +0200 [thread overview]
Message-ID: <87h6epef3s.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <87le41efeg.fsf@oldenburg.str.redhat.com> (Florian Weimer's message of "Wed, 22 May 2024 22:54:31 +0200")
* Florian Weimer:
> * DJ Delorie:
>
>> diff --git a/manual/startup.texi b/manual/startup.texi
>> index 96a7a472bb..f6e0ab909c 100644
>> --- a/manual/startup.texi
>> +++ b/manual/startup.texi
>> @@ -690,7 +690,31 @@ you don't need to know about it because you can just use @theglibc{}'s
>> @code{chmod} function.
>>
>> @cindex kernel call
>> -System calls are sometimes called kernel calls.
>> +System calls are sometimes called syscalls or kernel calls, and this
>> +interface is mostly a purely mechanical translation from the kernel's
>> +ABI to the C ABI. For the set of syscalls where we do not guarantee
>> +POSIX Thread cancellation the wrappers only organize the incoming
>> +arguments from the C calling convention to the calling convention of
>> +the target kernel. For the set of syscalls where we provided POSIX
>> +Thread cancellation the wrappers set some internal state in the
>> +library to support cancellation, but this does not impact the
>> +behaviour of the syscall provided by the kernel.
>> +
>> +@Theglibc{} includes by reference the Linux man-pages
>> +@value{man_pages_version} documentation to document the listed
>> +syscalls for the Linux kernel. For reference purposes only the latest
>> +@uref{https://www.kernel.org/doc/man-pages/,Linux man-pages Project}
>> +documentation can be accessed from the
>> +@uref{https://www.kernel.org,Linux kernel} website. Where the syscall
>> +has more specific documentation in this manual that more specific
>> +documentation is considered authoritative.
>> +
>> +Here is the list of all potential non-cancellable system calls, across
>> +all configurations of @theglibc():
>
> @theglibc() should be @theglibc{} (typographical error).
>
>> +@include syscalls.texi
>
> Should the list be separated by commas? It's currently space-separated
> only.
>
> The list still includes getuid, which is most emphatically not a single
> system call in multi-threaded programs, not on Linux and not on Hurd.
Actually setuid, but fortunately it's in the list as well.
>
>> +Here's the corresponding list of cancellable system calls:
>> +@include syscallsc.texi
>
> Unfortunately, this now gives the impression that the syscall function
> described below implements a cancellable system call when called for
> SYS_read (for example). But that's not accurate. System calls invoked
> through the syscall function are never cancellable.
>
> Maybe add to the commit message why we are adding this? Is this an
> attempt to achieve completeness of the manual by referencing the manual
> page for certain functions we do not document? Maybe it would be more
> approriate to add @deftypefn directives for those specific functions,
> with a stub that refers to the corresponding man-pages URL?
>
> Do we have a rendered version of the current development version that we
> can point people to for review purposes?
>
> Thanks,
> Florian
next prev parent reply other threads:[~2024-05-22 21:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 20:52 manual: add syscall list appendix DJ Delorie
2024-05-16 5:02 ` Florian Weimer
2024-05-16 11:44 ` Carlos O'Donell
2024-05-16 12:06 ` Florian Weimer
2024-05-16 13:37 ` Alejandro Colomar
2024-05-16 14:52 ` Carlos O'Donell
2024-05-16 15:03 ` Alejandro Colomar
2024-05-16 17:57 ` DJ Delorie
2024-05-16 17:55 ` DJ Delorie
2024-05-16 21:08 ` Alejandro Colomar
2024-05-17 13:21 ` Carlos O'Donell
2024-05-17 15:31 ` DJ Delorie
2024-05-17 19:16 ` Carlos O'Donell
2024-05-20 21:43 ` [patch v2] manual: add syscall list DJ Delorie
2024-05-20 22:10 ` Alejandro Colomar
2024-05-21 1:12 ` DJ Delorie
2024-05-21 10:22 ` Alejandro Colomar
2024-05-21 17:16 ` DJ Delorie
2024-05-21 20:04 ` [patch v3] " DJ Delorie
2024-05-22 19:07 ` Carlos O'Donell
2024-05-22 19:40 ` DJ Delorie
2024-05-22 19:41 ` [patch v4] " DJ Delorie
2024-05-22 19:42 ` DJ Delorie
2024-05-22 20:54 ` Florian Weimer
2024-05-22 21:00 ` Florian Weimer [this message]
2024-05-22 21:26 ` DJ Delorie
2024-05-23 7:31 ` Florian Weimer
2024-05-23 8:49 ` Andreas Schwab
2024-05-22 22:45 ` DJ Delorie
2024-05-22 23:12 ` Alejandro Colomar
2024-05-23 16:59 ` Zack Weinberg
2024-05-23 19:38 ` DJ Delorie
2024-05-23 19:41 ` Zack Weinberg
2024-05-23 19:46 ` DJ Delorie
2024-05-23 19:51 ` Joseph Myers
2024-05-23 21:18 ` Alejandro Colomar
2024-05-16 17:37 ` manual: add syscall list appendix DJ Delorie
2024-05-16 17:55 ` Joe Simmons-Talbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6epef3s.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=alx@kernel.org \
--cc=carlos@redhat.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).