From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by sourceware.org (Postfix) with ESMTPS id E92F73858C53 for ; Sun, 19 Mar 2023 13:49:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E92F73858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cipht.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cipht.net Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0C1E65C00A6; Sun, 19 Mar 2023 09:49:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 19 Mar 2023 09:49:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipht.net; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1679233774; x=1679320174; bh=5k Y8lEYo+XoKMpcJulh9BzaniGFqxGthdTEtTGKQMAw=; b=hcjmb70BkBnEPBL8VV VVuTafzGWpfc07W24ZI55JSKwIwcWAAmZYgLo/jXjMtRYbJ+WhZh+cPToReU8GsD uo0jUyVQUQNFfctN1wjzf6hOBwW/kwPE/S3ZmV4hFf+dygvjuGSAAR9fKQs/4Iuk T4iBMjAFJAdOl1xh4IY/8VlVqiE01K5AzXLP6YD90zzg1znLKfjlaGXaCvDVuVrd U9WiyoGTdZTH/UHe4ExLnwY2orFq/3KHBeNzkW33iAjXBqghavSqXG+CRZ8vNcQA BfuocdO1sqeniFMOZELu1e+w/GOSKJZJmBWfuNXVUDTRK21vOLVpVJYov3DBIhX0 zxxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679233774; x=1679320174; bh=5kY8lEYo+XoKM pcJulh9BzaniGFqxGthdTEtTGKQMAw=; b=BKC4i1slVn7JmrgmpH3/BDCPiNWzD pO+y4aXy2gC9Cw2zA2iYxFM5qHlH0Dcldkw9jYX7PsdqEoxaug5XAbntGceqxf/A CiOaQn7VmsvwuZtU1PvrJzs36IVY5A+nKcSNe++wp8PC2NDlH+0J045/w9eWjAfQ 9HB3uHrFs+s58QkvVSrrvqNY4Fd9DeYenAaEWDF9vNEmC0h3jCx0tjjQi/fbhSo4 gGEiMBQ1I5Z41tMmmP0BQhlgZLNDnZ5sktvwJTT07u7Wrvaafu7/5DpcHd/RuJET 0pPEATubdHInkGSa61mUj70OdcUwYSxKNypr1457jxtILbeO7QktMUiaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefiedgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesghdtreertderjeenucfhrhhomheplfhulhhi rghnucfuqhhuihhrvghsuceojhhulhhirghnsegtihhphhhtrdhnvghtqeenucggtffrrg htthgvrhhnpeevuddvieekfffgjeetgfetvefhkeetvdfhieejhfduffeujedttedtgfev tefgheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hjuhhlihgrnhestghiphhhthdrnhgvth X-ME-Proxy: Feedback-ID: icfd1466b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Mar 2023 09:49:33 -0400 (EDT) From: Julian Squires To: Andreas Schwab Cc: Julian Squires via Libc-alpha Subject: Re: [PATCH] posix: Fix some null deferences in wordexp [BZ #18096] In-Reply-To: <871qlmyu2f.fsf@igel.home> (Andreas Schwab's message of "Sat, 18 Mar 2023 16:10:00 +0100") References: <20230318125950.3611824-1-julian@cipht.net> <871qlmyu2f.fsf@igel.home> Date: Sun, 19 Mar 2023 11:19:27 -0230 Message-ID: <87h6ugx34o.fsf@cipht.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Andreas Schwab writes: > On M=C3=A4r 18 2023, Julian Squires via Libc-alpha wrote: >> @@ -1813,7 +1813,7 @@ envsubst: >> goto success; >>=20=20 >> value =3D pattern ? __strdup (pattern) : pattern; >> - free_value =3D 1; >> + free_value =3D !!pattern; > > What does that fix? The assertion failure mentioned, where seen_hash is set, triggering the assertion below, where free_value is set but value is NULL: if (seen_hash) { [...] if (free_value) { assert (value !=3D NULL); free (value); } =2D-=20 Julian Squires --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJFBAEBCgAvFiEEzIzFmZ3rNChYWalm5m0gEdptGGIFAmQXEucRHGp1bGlhbkBj aXBodC5uZXQACgkQ5m0gEdptGGKxZQ/+PwUmr64AQOOe9YvaoqddsiaiEcZhGf1O /404THlfxHFjEcMC97tH/4RKJUhppwOPchDYMn2eWTA2A8nAKj4sShIrerhXAy57 DFBNQWdjoNj59P1Unu7Em1vrxdZyqB6Ww/Pj0OMDs1Hg3nfOu5x/NX0e3p7o6JuR sVUa/Hkpu+He8ePBwqFlqtKAzzwbgkrbwQc4vIm560Yb+K0qFQAGpAS0n5bYFFDi 7Fla2jg6y/wlGvS3Bm6QXnxePVAA4O+3JdBopzY/c+Fn20MxTM8sT6GDh8mdgNZA WhzslWiF04OKR0gGQqIdn0+kIb8ajn5isEN6KpNLUln+P489uKgbB0O9oMUCo7fh EnbzLaOQuxRNqE1exsI653jIWHWQfxakpmNtA9BqbnRJGpjqPMfdyZN1gJhn+IKp VlMgx+IhFTwMy4GJR2NqHTWHkYiRGdxNJoYEo6Er/7/Ps4k6FXcTc2Lif+tN036H WYod9ky9W+RZZ8wTsDJIEzPWtN4B0IjWMzMiZUc+1MhmEcEib/zuS2vsyz6kwR/D +xJQh2+JUKLJHvc7+raoBctsJ1zP9dWCXSxwGm5QbIp12pIvthI7SDmegP5v2qIW o7/KK5nVYUu/B92JNXqZ3Eaz7KULZXJf/KxiuAnvQaCTYrApiJZ5hrm7VYKEOY4o Qgr4Vfg8w1w= =40KU -----END PGP SIGNATURE----- --=-=-=--