public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Rajalakshmi Srinivasaraghavan via Libc-alpha <libc-alpha@sourceware.org>
Cc: Rajalakshmi Srinivasaraghavan <rajis@linux.ibm.com>
Subject: Re: [PATCH] powerpc64: Increase SIGSTKSZ and MINSIGSTKSZ
Date: Tue, 13 Dec 2022 17:23:04 +0100	[thread overview]
Message-ID: <87h6xz9st3.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20221209011652.4109160-1-rajis@linux.ibm.com> (Rajalakshmi Srinivasaraghavan via Libc-alpha's message of "Thu, 8 Dec 2022 19:16:52 -0600")

* Rajalakshmi Srinivasaraghavan via Libc-alpha:

> This patch increases the value of SIGSTKSZ and MINSIGSTKSZ
> for powerpc64 similar to the kernel commit
> 2f82ec19757f58549467db568c56e7dfff8af283 to allow
> further expansion of the signal stack frame size.
> ---
>  sysdeps/unix/sysv/linux/powerpc/bits/sigstack.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/sysdeps/unix/sysv/linux/powerpc/bits/sigstack.h b/sysdeps/unix/sysv/linux/powerpc/bits/sigstack.h
> index abc87cd7a6..4bff1fe1e7 100644
> --- a/sysdeps/unix/sysv/linux/powerpc/bits/sigstack.h
> +++ b/sysdeps/unix/sysv/linux/powerpc/bits/sigstack.h
> @@ -23,10 +23,15 @@
>  # error "Never include this file directly.  Use <signal.h> instead"
>  #endif
>  
> +#ifdef __powerpc64__
> +#define MINSIGSTKSZ	8192
> +#define SIGSTKSZ	32768
> +#else
>  /* Minimum stack size for a signal handler.  */
>  #define MINSIGSTKSZ	4096
>  
>  /* System default stack size.  */
>  #define SIGSTKSZ	16384
> +#endif

This is technically an ABI change, but if you think this is the right
forward, you can certainly make that change.  It's not the path some
other architectures have taken when they faced similar problems, so I
don't think we have much experience in this area.

Should we backport this to older releases (or downstream)?

Thanks,
Florian


  parent reply	other threads:[~2022-12-13 16:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09  1:16 Rajalakshmi Srinivasaraghavan
2022-12-12 23:31 ` Paul E Murphy
2022-12-13  3:27   ` Adhemerval Zanella Netto
2022-12-13 13:41     ` Rajalakshmi Srinivasaraghavan
2022-12-21 23:58   ` Rajalakshmi Srinivasaraghavan
2022-12-13 16:23 ` Florian Weimer [this message]
2022-12-14 16:46   ` Rajalakshmi Srinivasaraghavan
2022-12-15 13:43     ` Tulio Magno Quites Machado Filho
2022-12-15 23:44       ` Rajalakshmi Srinivasaraghavan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6xz9st3.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=rajis@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).