From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	by sourceware.org (Postfix) with ESMTPS id B8745382EA20
	for <libc-alpha@sourceware.org>; Fri, 16 Sep 2022 09:53:50 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8745382EA20
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1663322030;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=QM/skuyMyVHxUWQ29y66ZJTIeyfMXOP6aw+fkhTVrpg=;
	b=LJPgle1D8dJj78ClKqbUn4OnUZIHzHPSyqgFPOAdTuHBg8YrHIY9aK4rnfxw+0tMaDQweW
	GTt94JrOdTholRTMzJHGGc3aScJys+ob4ZZcj4Dyp586z1H4vT6e1Eqj61omPWwNnBoomU
	EbXfNTmfpiiRQD9AiP+mp0bqwKKv2Pk=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-557-BOStL5xsO6Ss1VE1wMQ46g-1; Fri, 16 Sep 2022 05:53:17 -0400
X-MC-Unique: BOStL5xsO6Ss1VE1wMQ46g-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C5361185A792;
	Fri, 16 Sep 2022 09:53:16 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.192.34])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 407D22087440;
	Fri, 16 Sep 2022 09:53:16 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Letu Ren via Libc-alpha <libc-alpha@sourceware.org>
Cc: Letu Ren <fantasquex@gmail.com>
Subject: Re: [PATCH] stdlib/strfrom: Remove the -NAN testcase (bug 29501)
References: <20220915174421.4414-1-fantasquex@gmail.com>
Date: Fri, 16 Sep 2022 11:53:14 +0200
In-Reply-To: <20220915174421.4414-1-fantasquex@gmail.com> (Letu Ren via
	Libc-alpha's message of "Fri, 16 Sep 2022 01:44:21 +0800")
Message-ID: <87h717zlv9.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Letu Ren via Libc-alpha:

> diff --git a/stdlib/tst-strfrom.c b/stdlib/tst-strfrom.c
> index 3a447eac12..1533fb9170 100644
> --- a/stdlib/tst-strfrom.c
> +++ b/stdlib/tst-strfrom.c
> @@ -37,7 +37,6 @@ static const struct test tests[] = {
>    TEST ("5.900000e-16", "%e", 50, 12, 5.9e-16),
>    TEST ("1.234500e+20", "%e", 50, 12, 12.345e19),
>    TEST ("1.000000e+05", "%e", 50, 12, 1e5),
> -  TEST ("-NAN", "%G", 50, 4, -NAN_),
>    TEST ("-inf", "%g", 50, 4, -INF),
>    TEST ("inf", "%g", 50, 3, INF)
>  };

Shouldn't the test verify that the result is "NAN" or "-NAN"?  That part
is still valid.

Thanks,
Florian