From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	by sourceware.org (Postfix) with ESMTPS id CC7983858D1E
	for <libc-alpha@sourceware.org>; Thu,  8 Sep 2022 11:23:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC7983858D1E
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1662636206;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=vXxX+7JZYjUfmHLffN5Nlf5daDOq6dEVjwbU0HW6VAw=;
	b=DgC4VrMVijHO26RXy6+odgvQcEJgdRbqKSSIA+AS1oomSQJ2crS1Vn1wNSHmL3FwomE0I8
	Z5pRBri5vQU/aX7BUL2d4P6h939IVhm9B3mHojS9gLl0B0XCUMOj7vdLPrmhPJzJhG1F/m
	6icZg4FR5SIoFYMzW7pAFWtsgwVFDwY=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-361-uaEUrd_oMg6KDqiFeZVAFw-1; Thu, 08 Sep 2022 07:23:23 -0400
X-MC-Unique: uaEUrd_oMg6KDqiFeZVAFw-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3555A101A54E;
	Thu,  8 Sep 2022 11:23:23 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.192.44])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 6089840CF8F0;
	Thu,  8 Sep 2022 11:23:22 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Javier Pello <devel@otheo.eu>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 0/4] elf: Fix hwcaps string size overestimation
References: <20220905200652.d69204581d15c64647da5cd2@otheo.eu>
	<87h71l9crb.fsf@oldenburg.str.redhat.com>
	<20220906201207.e7b3d08272af5649754e76b1@otheo.eu>
Date: Thu, 08 Sep 2022 13:23:21 +0200
In-Reply-To: <20220906201207.e7b3d08272af5649754e76b1@otheo.eu> (Javier
	Pello's message of "Tue, 6 Sep 2022 20:12:07 +0200")
Message-ID: <87h71i6rfa.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Javier Pello:

>> We deprecated this mechanism in glibc 2.33.  I think it's time
>> to remove it in glibc 2.37.
>> 
>> Since you are evidently familiar with the code now,
>
> That may be a bit of a stretch. :-)
>
>> would like to implement the removal?
>
> What would this removal be? Do you want _dl_important_hwcaps to
> return only the glibc-hwcaps subdirectories, and not the legacy
> hwcaps power set subdirectories? That should be doable.

Exactly.  And in separate commits, update ldconfig and the cache reading
logic in elf/dl-cache.c.

> In any case, even if hwcaps power set support is removed, I think
> that at least my first patch sould be applied first. If the removal
> were to be reverted later, or if somebody looked at the code as it
> was before the removal for whatever reason, I think that it would
> be better if it had been left in the best possible shape, at least
> with the overallocation bug fixed.

Agreed.

Thanks,
Florian