From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C48693857C72 for ; Tue, 30 Aug 2022 11:13:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C48693857C72 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661858011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cNHpnAHq4pin6uwP5AsWwtHh7ZUia1qyEAzYBU5mf6w=; b=SZcs6ysYuTdRbZZ2AdYM0Z4hPUL1GZfihbOZn0rvmE0x9eTwOgOO/U9XG+h2ubfgWJaiZ7 8xvZ7wycCaZm0HO6HVMIIgHiJlT3w7/RMOwYG/Q3b13XwHBhJdJxGSWttnxt4NslXWq2/y tXpm+O1lzVYyEpsU3slzySRGlcemlwQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-262-wQdsZ9YRMwiOIIpeOVk46Q-1; Tue, 30 Aug 2022 07:13:28 -0400 X-MC-Unique: wQdsZ9YRMwiOIIpeOVk46Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 28072185A7BA; Tue, 30 Aug 2022 11:13:28 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 50EEA909FF; Tue, 30 Aug 2022 11:13:27 +0000 (UTC) From: Florian Weimer To: Szabolcs Nagy Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 12/13] resolv: Add new tst-resolv-invalid-cname References: <877c0c619e3e338ce85e6a8d9e15c1f23b001954.1661509943.git.fweimer@redhat.com> Date: Tue, 30 Aug 2022 13:13:25 +0200 In-Reply-To: (Szabolcs Nagy's message of "Tue, 30 Aug 2022 11:59:37 +0100") Message-ID: <87h71u56i2.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Szabolcs Nagy: > The 08/26/2022 12:34, Florian Weimer via Libc-alpha wrote: >> This test checks resolution through CNAME chains that do not contain >> host names (bug 12154). >> >> Reviewed-by: Siddhesh Poyarekar >> --- >> resolv/Makefile | 3 + >> resolv/tst-resolv-invalid-cname.c | 406 ++++++++++++++++++++++++++++++ >> 2 files changed, 409 insertions(+) >> create mode 100644 resolv/tst-resolv-invalid-cname.c > ... >> +static const char * >> +test_mode_to_string (enum test_mode mode) >> +{ >> + switch (mode) >> + { >> + case byname: >> + return "byname"; >> + case byname2: >> + return "byname2"; >> + case gai: >> + return "gai"; >> + case gai_canon: >> + return "gai_canon"; >> + case test_mode_num: >> + /* Report error below. */ >> + } >> + FAIL_EXIT1 ("invalid test_mode: %d", mode); >> +} > > with gcc-8 i see build failure like > > tst-resolv-invalid-cname.c: In function 'test_mode_to_string': > tst-resolv-invalid-cname.c:164:10: error: label at end of compound statement > case test_mode_num: > ^~~~~~~~~~~~~ > make[2]: *** [../o-iterator.mk:9: /work/glibc-aarch64-linux/build/build/resolv/tst-resolv-invalid-cname.o] Error 1 Ugh, not again. I will fix shortly. Thanks, Florian