From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by sourceware.org (Postfix) with ESMTPS id 0FBA13954424
 for <libc-alpha@sourceware.org>; Tue,  3 May 2022 16:44:02 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0FBA13954424
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-177-a78e3g1TNFSiP45JACxn6A-1; Tue, 03 May 2022 12:43:57 -0400
X-MC-Unique: a78e3g1TNFSiP45JACxn6A-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com
 [10.11.54.2])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7998A1C05137;
 Tue,  3 May 2022 16:43:57 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.193.113])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id EFA3040D2820;
 Tue,  3 May 2022 16:43:56 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/5] Linux: Implement a useful version of _startup_fatal
References: <cover.1651518694.git.fweimer@redhat.com>
 <7a6a51b346a81484046ba392a9854a88568a92aa.1651518694.git.fweimer@redhat.com>
 <CAMe9rOpdARCeL7RoDXqYYBYA2dHS3HEHr0Lu_RN7ioO2wyYOwQ@mail.gmail.com>
 <87ilqn4spx.fsf@oldenburg.str.redhat.com>
 <CAMe9rOqp8YAy5Xopm8++s0L=UfgVssqDz7FG4TTydDpN5hoU4Q@mail.gmail.com>
 <877d734qne.fsf@oldenburg.str.redhat.com>
 <87bkwfxkhg.fsf@oldenburg.str.redhat.com>
 <CAMe9rOo3iPYVT0F2mGkrSht13KDt_Hm9TXD+8EQSe0L7gdrwBw@mail.gmail.com>
 <87levifvwm.fsf@oldenburg.str.redhat.com>
 <CAMe9rOrMuS8RgAFat9DYy3FGFDM9keHigRvbxfu0yoE0LGK6Eg@mail.gmail.com>
Date: Tue, 03 May 2022 18:43:55 +0200
In-Reply-To: <CAMe9rOrMuS8RgAFat9DYy3FGFDM9keHigRvbxfu0yoE0LGK6Eg@mail.gmail.com>
 (H. J. Lu's message of "Tue, 3 May 2022 09:36:23 -0700")
Message-ID: <87h766ftx0.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_NONE, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 03 May 2022 16:44:04 -0000

* H. J. Lu:

> On Tue, May 3, 2022 at 9:01 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * H. J. Lu:
>>
>> > The startup codes can't use cancellation before it is ready.  Do we need to
>> > check SHARED in this case?
>>
>> I think __libc_fatal shouldn't be a cancellation point.  That's not
>> really related to SHARED.
>
> Should we define _startup_fatal unconditionally and always define
> I386_USE_SYSENTER as 0 for i386 so that _startup_fatal can be
> used safely during startup?

Hmm.  Isn't that what my patch does?

Thanks,
Florian