From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CE72E385734C for ; Tue, 12 Apr 2022 09:53:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CE72E385734C Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-605-GmVBsPAFNM61HODVvEZ2rw-1; Tue, 12 Apr 2022 05:53:03 -0400 X-MC-Unique: GmVBsPAFNM61HODVvEZ2rw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 97EA6800B28; Tue, 12 Apr 2022 09:53:03 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C0051416375; Tue, 12 Apr 2022 09:53:02 +0000 (UTC) From: Florian Weimer To: Samuel Thibault Cc: libc-alpha@sourceware.org Subject: Re: [PATCH,hurd] Fix arbitrary error code References: <20220412094434.nqpydlozpprrkg6r@begin> Date: Tue, 12 Apr 2022 11:53:01 +0200 In-Reply-To: <20220412094434.nqpydlozpprrkg6r@begin> (Samuel Thibault's message of "Tue, 12 Apr 2022 11:44:34 +0200") Message-ID: <87h76yhblu.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2022 09:53:07 -0000 * Samuel Thibault: > ELIBBAD is Linux-specific, Hurd has EGRATUITOUS instead. > > diff --git a/nss/nss_test_errno.c b/nss/nss_test_errno.c > index 680f8a07b9..d27368f4f3 100644 > --- a/nss/nss_test_errno.c > +++ b/nss/nss_test_errno.c > @@ -28,7 +28,13 @@ static void __attribute__ ((constructor)) > init (void) > { > /* An arbitrary error code which is otherwise not used. */ > +#if defined(__linux__) > errno = ELIBBAD; > +#elif defined(__GNU__) > + errno = EGRATUITOUS; > +#else > +#error missing arbitrary error code > +#endif > } > > /* Lookup functions for pwd follow that do not return any data. */ I don't see a build failure because of this? Maybe we can pick another shared error code? Related question: Would it be possible to add ELIBEXEC to Hurd some day? Thanks, Florian