From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2C2BC3858405 for ; Fri, 11 Feb 2022 11:43:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2C2BC3858405 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-426-buVzJ2HCO0yAMtTPzJx3Zg-1; Fri, 11 Feb 2022 06:43:11 -0500 X-MC-Unique: buVzJ2HCO0yAMtTPzJx3Zg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D62AF46885; Fri, 11 Feb 2022 11:43:02 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9D3866E22; Fri, 11 Feb 2022 11:43:01 +0000 (UTC) From: Florian Weimer To: Stafford Horne Cc: Adhemerval Zanella , libc-alpha@sourceware.org Subject: Re: [PATCH] resolv: Do not build libanl.so for ABIs starting at 2.35 References: <20211229163951.3517051-1-adhemerval.zanella@linaro.org> <87czlfb6wk.fsf@oldenburg.str.redhat.com> <7b27dffe-c63a-fc3e-9f2b-741f96ac2b21@linaro.org> Date: Fri, 11 Feb 2022 12:42:59 +0100 In-Reply-To: (Stafford Horne's message of "Fri, 11 Feb 2022 20:34:54 +0900") Message-ID: <87h795vdbw.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2022 11:43:16 -0000 * Stafford Horne: > One more thing, sorry I just picked this up now. After the fixes we are now > getting: > > make: Entering directory '/home/shorne/work/gnu-toolchain/glibc/resolv' > make: *** No rule to make target '/home/shorne/work/gnu-toolchain/build-glibc/resolv/tst-resolv-res_ninit.out', needed by '/home/shorne/work/gnu-toolchain/build-glibc/resolv/mtrace-tst-resolv-res_ninit.out'. Stop. > make: Leaving directory '/home/shorne/work/gnu-toolchain/glibc/resolv' > > The "if" condition change blocked many of the tst-resolv* tests from being > built or run for 2.35 only ports. Is that expected? There are now a few > things like above that are missing their dependencies. Do we need: > > diff --git a/resolv/Makefile b/resolv/Makefile > index c465479e8b..11e3b203a3 100644 > --- a/resolv/Makefile > +++ b/resolv/Makefile > @@ -84,7 +84,9 @@ endif > ifeq ($(have-GLIBC_2.34)$(have-thread-library),yesyes) > # Empty compatibility library for old binaries. > extra-libs += libanl > +endif > > +ifeq ($(have-thread-library),yes) > tests += \ > tst-bug18665 \ > tst-bug18665-tcp \ Sorry about that, I should have reviewed this more closely. Can you move the libanl settings closer together? $(libanl-routines-var) should be outside the $(have-GLIBC_2.34) condition, libanl-routines += libanl-compat should be inside it. Thanks, Florian