From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 38FC6385ED40 for ; Thu, 27 Jan 2022 16:12:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38FC6385ED40 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-504-M2VE-iFyOjaVLGcdA3PHXA-1; Thu, 27 Jan 2022 11:12:29 -0500 X-MC-Unique: M2VE-iFyOjaVLGcdA3PHXA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98A92835B52; Thu, 27 Jan 2022 16:12:28 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A7364753C2; Thu, 27 Jan 2022 16:11:55 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Carlos O'Donell Subject: Re: [PATCH] posix: Replace posix_spawnattr_tc{get,set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np References: <20220127141400.3364940-1-adhemerval.zanella@linaro.org> Date: Thu, 27 Jan 2022 17:11:54 +0100 In-Reply-To: <20220127141400.3364940-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Thu, 27 Jan 2022 11:14:00 -0300") Message-ID: <87h79pma45.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 16:12:34 -0000 * Adhemerval Zanella: > The posix_spawnattr_tcsetpgrp_np works on a file descriptor (the > controlling terminal), so it would make more sense to actually fit > it on the file actions API. > > Also, POSIX_SPAWN_TCSETPGROUP is not really required since it is > implicit by the presence of tcsetpgrp file action. > > The posix/tst-spawn6.c is also fixed when TTY can is not present. > > Checked on x86_64-linux-gnu and i686-linux-gnu. This has an ABI check failure on Hurd: --- ../sysdeps/mach/hurd/i386/libc.abilist 2022-01-27 10:04:20.120812828 -0500 +++ /home/bmg/build/glibcs/i686-gnu/glibc/libc.symlist 2022-01-27 10:43:39.646804376 -0500 @@ -2292,2 +2291,0 @@ GLIBC_2.35 posix_spawn_file_actions_addt -GLIBC_2.35 posix_spawnattr_tcgetpgrp_np F -GLIBC_2.35 posix_spawnattr_tcsetpgrp_np F The changes look okay to me. A second review is probably warranted at this stage. Thanks, Florian