From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Properly check linker option in LIBC_LINKER_FEATURE [BZ #28738]
Date: Mon, 03 Jan 2022 12:20:35 +0100 [thread overview]
Message-ID: <87h7aljcak.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220102141623.589517-1-hjl.tools@gmail.com> (H. J. Lu via Libc-alpha's message of "Sun, 2 Jan 2022 06:16:23 -0800")
* H. J. Lu via Libc-alpha:
> Update LIBC_LINKER_FEATURE to also check linker warning message since
> unknown linker -z option may be ignored by linker:
>
> $ touch x.c
> $ gcc -shared -Wl,-z,foobar x.c
> /usr/bin/ld: warning: -z foobar ignored
> $ echo $?
> 0
> $
>
> This fixes BZ #28738.
Looks okay to me.
Thanks,
Florian
next prev parent reply other threads:[~2022-01-03 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-02 14:16 H.J. Lu
2022-01-03 11:20 ` Florian Weimer [this message]
2022-01-04 18:37 ` Joseph Myers
2022-01-04 18:47 ` [PATCH] Set LC_ALL=C for " H.J. Lu
2022-01-04 21:47 ` [PATCH] Properly check linker option in " Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7aljcak.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).