From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 49E9D385840F for ; Mon, 13 Dec 2021 11:46:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49E9D385840F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4JCKTf56R8z1r86w; Mon, 13 Dec 2021 12:46:14 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4JCKTf4SlXz1qqkB; Mon, 13 Dec 2021 12:46:14 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id DOnhVBnP_ahy; Mon, 13 Dec 2021 12:46:13 +0100 (CET) X-Auth-Info: wO6dT402fO5Ip6M12kNTju7TysaGBMU8o7L2JJSzPWZhTOcqZvSTOzKZBd9Zvf9W Received: from igel.home (ppp-46-244-181-78.dynamic.mnet-online.de [46.244.181.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 13 Dec 2021 12:46:13 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 2D25B2C2545; Mon, 13 Dec 2021 12:46:13 +0100 (CET) From: Andreas Schwab To: Rongwei Wang via Libc-alpha Cc: hjl.tools@gmail.com, fweimer@redhat.com, adhemerval.zanella@linaro.org, Rongwei Wang , xuyu@linux.alibaba.com, gavin.dg@linux.alibaba.com Subject: Re: [PATCH v6 1/2] elf: Properly align PT_LOAD segments [BZ #28676] References: <20211204045848.71105-1-rongwei.wang@linux.alibaba.com> <20211213025103.48472-1-rongwei.wang@linux.alibaba.com> <20211213025103.48472-2-rongwei.wang@linux.alibaba.com> X-Yow: An INK-LING? Sure -- TAKE one!! Did you BUY any COMMUNIST UNIFORMS?? Date: Mon, 13 Dec 2021 12:46:13 +0100 In-Reply-To: <20211213025103.48472-2-rongwei.wang@linux.alibaba.com> (Rongwei Wang via Libc-alpha's message of "Mon, 13 Dec 2021 10:51:02 +0800") Message-ID: <87h7bczq0q.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2021 11:46:18 -0000 On Dez 13 2021, Rongwei Wang via Libc-alpha wrote: > + else > + { > + /* Unmap the unused regions. */ > + ElfW(Addr) delta = map_start_aligned - map_start; > + if (delta) > + __munmap ((void *) map_start, delta); > + ElfW(Addr) map_end = map_start_aligned + maplength; > + delta = map_start + maplen - map_end; > + if (delta) > + __munmap ((void *) map_end, delta); I don't think map_end is guaranteed to be page-aligned. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."