From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 32146385B83F for ; Tue, 16 Nov 2021 13:48:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 32146385B83F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-GuCmoW3mNAm2xQc7p71TZQ-1; Tue, 16 Nov 2021 08:48:11 -0500 X-MC-Unique: GuCmoW3mNAm2xQc7p71TZQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 870CB15720; Tue, 16 Nov 2021 13:48:10 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 661A81F429; Tue, 16 Nov 2021 13:48:09 +0000 (UTC) From: Florian Weimer To: Andreas Schwab Cc: Adhemerval Zanella via Libc-alpha , Adhemerval Zanella , John Mellor-Crummey Subject: Re: [PATCH v6 01/20] elf: Suppress audit calls when a (new) namespace is empty (BZ #28062) References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-2-adhemerval.zanella@linaro.org> <87ee7hfdk7.fsf@oldenburg.str.redhat.com> <37adfe77-f066-8046-2fe4-5026d3bdac1c@linaro.org> <877dd8uscm.fsf@igel.home> Date: Tue, 16 Nov 2021 14:48:07 +0100 In-Reply-To: <877dd8uscm.fsf@igel.home> (Andreas Schwab's message of "Tue, 16 Nov 2021 14:45:29 +0100") Message-ID: <87h7ccciug.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 13:48:16 -0000 * Andreas Schwab: > On Nov 16 2021, Adhemerval Zanella via Libc-alpha wrote: > >> + /* Auditing checkpoint: we are going to add new objects. Since this >> + is called after _dl_add_to_namespace_list() the namespace is > > Not a function call here. I've stopped pointing those out in patch reviews. Is this GNU convention really useful? If there is no other markup, it often increases readability, particular for identifiers that are also bona fide English words, such as read and close. Thanks, Florian