From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v9 00/10] malloc hooks removal
Date: Mon, 19 Jul 2021 13:20:54 +0200 [thread overview]
Message-ID: <87h7gqy2g9.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <f9036b73-42e5-e33c-6505-464fd82f461a@sourceware.org> (Siddhesh Poyarekar's message of "Mon, 19 Jul 2021 16:47:17 +0530")
* Siddhesh Poyarekar:
> On 7/19/21 4:41 PM, Florian Weimer wrote:
>> * Siddhesh Poyarekar:
>>
>>> On 7/19/21 4:37 PM, Florian Weimer via Libc-alpha wrote:
>>>> This series break old Emacs binaries (e.g. emacs-24.3-23.el7.x86_64):
>>>> $ bash testrun.sh /usr/bin/emacs
>>>
>>> Do they work if you run with LD_PRELOAD=malloc/libc_malloc_debug.so?
>> Basic testing suggests it works.
>
> The thing is, set_malloc_state will just not be called without the
> preload, so it doesn't matter what it returns. What we need to make a
> more graceful exit is to detect the existence of a non-NULL
> __malloc_initialize_hook within libc.so and abort. I'm not sure if
> it's worth the effort.
We could remove both symbols from libc.so.6. That would result in error
that can be found with search engines.
Thanks,
Florian
next prev parent reply other threads:[~2021-07-19 11:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 2:41 Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 01/10] Make mcheck tests conditional on GLIBC_2.23 or earlier Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 02/10] Remove __after_morecore_hook Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 03/10] Remove __morecore and __default_morecore Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 04/10] Move malloc hooks into a compat DSO Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 05/10] mcheck: Wean away from malloc hooks [BZ #23489] Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 06/10] Simplify __malloc_initialized Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 07/10] mtrace: Wean away from malloc hooks Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 08/10] glibc.malloc.check: " Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 09/10] Remove malloc hooks [BZ #23328] Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 10/10] mcheck Fix malloc_usable_size [BZ #22057] Siddhesh Poyarekar
2021-07-19 11:07 ` [PATCH v9 00/10] malloc hooks removal Florian Weimer
2021-07-19 11:09 ` Siddhesh Poyarekar
2021-07-19 11:11 ` Florian Weimer
2021-07-19 11:17 ` Siddhesh Poyarekar
2021-07-19 11:20 ` Florian Weimer [this message]
2021-07-19 11:40 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7gqy2g9.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).