From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 2BA9739C0C36 for ; Fri, 25 Jun 2021 08:53:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2BA9739C0C36 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-243-x9Tg_eFdO3GKNHozeSQHzw-1; Fri, 25 Jun 2021 04:53:19 -0400 X-MC-Unique: x9Tg_eFdO3GKNHozeSQHzw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A98888015F8; Fri, 25 Jun 2021 08:53:18 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-228.ams2.redhat.com [10.36.112.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC3B260CA0; Fri, 25 Jun 2021 08:53:17 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 34/34] Linux: Cleanups after librt move References: <19f1f247-eae9-171a-bf29-1e4baefa674c@linaro.org> Date: Fri, 25 Jun 2021 10:53:15 +0200 In-Reply-To: <19f1f247-eae9-171a-bf29-1e4baefa674c@linaro.org> (Adhemerval Zanella's message of "Thu, 24 Jun 2021 14:45:51 -0300") Message-ID: <87h7hmgwas.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jun 2021 08:53:23 -0000 * Adhemerval Zanella: > On 17/06/2021 16:00, Florian Weimer via Libc-alpha wrote: >> librt.so is no longer installed for PTHREAD_IN_LIBC, and tests >> are not linked against it. >> >> GLIBC_PRIVATE symbols that were needed during the transition are >> removed again. > > There are some more leftover I recently added to add timers on time64 > tests: > > ifeq (yes,$(build-shared)) > librt = $(common-objpfx)rt/librt.so > else > librt = $(common-objpfx)rt/librt.a > endif > > The patch looks ok, but you might want to update it against master. Okay, given that those are in generic code, we need to bring back $(librt). Thanks, Florian