From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 084B2385802A for ; Tue, 27 Apr 2021 06:45:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 084B2385802A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-393-qs2PHfX_Pp2wi1dmHe9vyA-1; Tue, 27 Apr 2021 02:45:56 -0400 X-MC-Unique: qs2PHfX_Pp2wi1dmHe9vyA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C2C4D1006C80; Tue, 27 Apr 2021 06:45:55 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-20.ams2.redhat.com [10.36.113.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB46B50C0D; Tue, 27 Apr 2021 06:45:54 +0000 (UTC) From: Florian Weimer To: =?utf-8?Q?=C3=89rico?= Nogueira via Libc-alpha Cc: =?utf-8?Q?=C3=89rico?= Nogueira Subject: Re: [RFC] linux: use __fd_to_filename helper function instead of snprintf. References: <20210427030937.10380-1-ericonr@disroot.org> Date: Tue, 27 Apr 2021 08:46:21 +0200 In-Reply-To: <20210427030937.10380-1-ericonr@disroot.org> (=?utf-8?Q?=22?= =?utf-8?Q?=C3=89rico?= Nogueira via Libc-alpha"'s message of "Tue, 27 Apr 2021 00:09:37 -0300") Message-ID: <87h7jsp6ma.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2021 06:46:00 -0000 * =C3=89rico Nogueira via Libc-alpha: > diff --git a/sysdeps/unix/sysv/linux/fexecve.c b/sysdeps/unix/sysv/linux/= fexecve.c > index f37c245396..218337a3b5 100644 > --- a/sysdeps/unix/sysv/linux/fexecve.c > +++ b/sysdeps/unix/sysv/linux/fexecve.c > @@ -22,6 +22,7 @@ > #include > #include > =20 > +#include > #include > #include > #include > @@ -50,8 +51,8 @@ fexecve (int fd, char *const argv[], char *const envp[]= ) > #ifndef __ASSUME_EXECVEAT > /* We use the /proc filesystem to get the information. If it is not > mounted we fail. */ > - char buf[sizeof "/proc/self/fd/" + sizeof (int) * 3]; > - __snprintf (buf, sizeof (buf), "/proc/self/fd/%d", fd); > + struct fd_to_filename filename; > + char *buf =3D fd_to_filename(fd, &filename); Sorry, this patch fails to build if applied to current master: ../sysdeps/unix/sysv/linux/fexecve.c: In function =E2=80=98fexecve=E2=80=99= : ../sysdeps/unix/sysv/linux/fexecve.c:55:15: error: implicit declaration of = function =E2=80=98fd_to_filename=E2=80=99 [-Werror=3Dimplicit-function-decl= aration] 55 | char *buf =3D fd_to_filename(fd, &filename); | ^~~~~~~~~~~~~~ Please also add a space before the opening '(', to match GNU style, and consider if the code becomes clearer if you avoid the buf variable. Thanks, Florian