From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id D54EF3857C5F for ; Wed, 24 Mar 2021 14:32:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D54EF3857C5F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-186-oauOWdFaM8O2t1C66CJ6Lw-1; Wed, 24 Mar 2021 10:32:29 -0400 X-MC-Unique: oauOWdFaM8O2t1C66CJ6Lw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0D428BE260; Wed, 24 Mar 2021 14:32:28 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-80.ams2.redhat.com [10.36.112.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0236F866C1; Wed, 24 Mar 2021 14:32:27 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 24/37] nptl: Move pthread_key_create, __pthread_key_create into libc References: <5118e919-fac6-a116-5f39-3915fdc0e0af@linaro.org> Date: Wed, 24 Mar 2021 15:32:48 +0100 In-Reply-To: <5118e919-fac6-a116-5f39-3915fdc0e0af@linaro.org> (Adhemerval Zanella's message of "Wed, 24 Mar 2021 11:09:10 -0300") Message-ID: <87h7l0wrjj.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 14:32:33 -0000 * Adhemerval Zanella: >> @@ -86,7 +88,9 @@ libc { >> } >> GLIBC_2.34 { >> __pthread_cleanup_routine; >> + __pthread_key_create; >> __pthread_once; >> + pthread_key_create; >> pthread_mutex_consistent; >> pthread_once; >> } > > Why do we need a __pthread_key_create for 2.34? __pthread_key_create is used by libstdc++. >> @@ -47,5 +47,18 @@ __pthread_key_create (pthread_key_t *key, void (*destr) (void *)) >> >> return EAGAIN; >> } >> -weak_alias (__pthread_key_create, pthread_key_create) >> -hidden_def (__pthread_key_create) >> +versioned_symbol (libc, __pthread_key_create_1, __pthread_key_create, >> + GLIBC_2_34); >> +libc_hidden_ver (__pthread_key_create_1, __pthread_key_create) >> + >> +/* Several aliases for setting different symbol versions. */ >> +strong_alias (__pthread_key_create_1, __pthread_key_create_2) >> +strong_alias (__pthread_key_create_1, __pthread_key_create_3) >> +strong_alias (__pthread_key_create_1, __pthread_key_create_4) >> + >> +versioned_symbol (libc, __pthread_key_create_2, pthread_key_create, >> + GLIBC_2_34); >> +#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_34) >> +compat_symbol (libc, __pthread_key_create_3, __pthread_key_create, GLIBC_2_0); >> +compat_symbol (libc, __pthread_key_create_4, pthread_key_create, GLIBC_2_0); >> +#endif > > I think you might want to revise it once compat_symbol has support > for multiple targets. Right that, applies in other places throughout the series, too. Speaking of which, should I repost the compat_symbol patches? Thanks, Florian