From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id DE19A3860C2D for ; Fri, 19 Mar 2021 19:13:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DE19A3860C2D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-w7lCpfurN1WIXX7eph8TBw-1; Fri, 19 Mar 2021 15:13:06 -0400 X-MC-Unique: w7lCpfurN1WIXX7eph8TBw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 012E381625; Fri, 19 Mar 2021 19:13:05 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-80.ams2.redhat.com [10.36.112.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2536710013D7; Fri, 19 Mar 2021 19:13:03 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [RFC 2/2] Fold compat_symbol_unique functionality into compat_symbol References: <965a0d7e0c28a5a0ce292a2b0bd39f2ba31d1a84.1616095061.git.fweimer@redhat.com> Date: Fri, 19 Mar 2021 20:13:14 +0100 In-Reply-To: (Adhemerval Zanella's message of "Fri, 19 Mar 2021 15:59:00 -0300") Message-ID: <87h7l7j6t1.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Mar 2021 19:13:09 -0000 * Adhemerval Zanella: >> In locale/lc-ctype.c, it seems prudent to switch to >> compat_symbol_reference. It produces .symver directives directly, as >> before. This side-steps the question of copy relocations, as >> mentioned in the comment. > > Maybe move this change on a subsequent patch? It's actually necessary to avoid build failures on some m68k variants, which duplicate the inline asm (it's in a function, so the compiler can do that), resulting in build failures due to .equiv instead of .set. (I switched to .equiv because some assemblers use .set for something unrelated to symbols.) I can make the change before this patch, though. >> diff --git a/nptl/libpthread-compat.c b/nptl/libpthread-compat.c >> index 820dcd6a8f..da537af76e 100644 >> --- a/nptl/libpthread-compat.c >> +++ b/nptl/libpthread-compat.c >> @@ -20,10 +20,10 @@ >> #include >> >> #ifdef SHARED >> -static void >> +void >> attribute_compat_text_section >> __attribute_used__ >> -__libpthread_version_placeholder (void) >> +__libpthread_version_placeholder_1 (void) >> { >> } >> #endif > > I don't think there is the need to change the symbol name, on my > test the compat_symbol can origin and alias can be the same name. It's necessary because the symbol version is no longer attached to the symbol, so it's version-less and gets exported with the default baseline, which could be something like GLIBC_2.17. I can mention this in the commit message. Thanks, Florian