From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 4D794385800C for ; Wed, 24 Feb 2021 10:45:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4D794385800C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=whitebox@nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DlsyY5xDsz1qtdT; Wed, 24 Feb 2021 11:45:41 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DlsyY5k7rz1r13Y; Wed, 24 Feb 2021 11:45:41 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ynfSqsaFuha3; Wed, 24 Feb 2021 11:45:41 +0100 (CET) X-Auth-Info: 1KffyPwyQyDDlniP53e32p2CFfwEJ5ZCBk6Drb58n0GiaVlviEUNfFm0A24QWk2W Received: from igel.home (ppp-46-244-188-88.dynamic.mnet-online.de [46.244.188.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 24 Feb 2021 11:45:41 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 5FF3B2C3695; Wed, 24 Feb 2021 11:45:40 +0100 (CET) From: Andreas Schwab To: DJ Delorie via Libc-alpha Subject: Re: [PATCH v2] nss: fix nss_database_lookup2's alternate handling [BZ #27416] References: <202102232356.11NNuYvW032419@greed.delorie.com> X-Yow: Uh-oh -- WHY am I suddenly thinking of a VENERABLE religious leader frolicking on a FORT LAUDERDALE weekend? Date: Wed, 24 Feb 2021 11:45:40 +0100 In-Reply-To: <202102232356.11NNuYvW032419@greed.delorie.com> (DJ Delorie via Libc-alpha's message of "Mon, 15 Feb 2021 21:34:23 -0500") Message-ID: <87h7m1d9rf.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2021 10:45:44 -0000 On Feb 15 2021, DJ Delorie via Libc-alpha wrote: > + /* Primary name not found, try alternate. */ > + if (alternate_name) > + for (database_id = 0; database_names[database_id]; database_id++) > + if (strcmp (database_names[database_id], alternate_name) == 0) > + if (__nss_database_get (database_id, ni) && *ni != NULL) > + return 0; Please add a test case where this block is reached. > + /* Neither found, use default config. */ > + *ni = __nss_action_parse (defconfig); > + if (*ni != NULL) > + return 0; Please add a test case where this block is reached. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."