From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 7B52D385780E for ; Fri, 9 Oct 2020 17:09:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7B52D385780E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-4BhfBmuXPHmZaB1fDEOn9g-1; Fri, 09 Oct 2020 13:09:01 -0400 X-MC-Unique: 4BhfBmuXPHmZaB1fDEOn9g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6E2F718C9F42; Fri, 9 Oct 2020 17:09:00 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-154.ams2.redhat.com [10.36.113.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7A8C6EF76; Fri, 9 Oct 2020 17:08:59 +0000 (UTC) From: Florian Weimer To: Matheus Castanho Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 14/28] elf: Enhance ld.so --help to print HWCAP subdirectories References: Date: Fri, 09 Oct 2020 19:08:58 +0200 In-Reply-To: (Matheus Castanho's message of "Fri, 9 Oct 2020 10:49:58 -0300") Message-ID: <87h7r3ba39.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2020 17:09:06 -0000 * Matheus Castanho: > I could reproduce this on both ppc64le and x84_64 with > --disable-tunables. Are we missing an `#include `? > > diff --git a/elf/dl-usage.c b/elf/dl-usage.c > index c07f43835b..796ad38b43 100644 > --- a/elf/dl-usage.c > +++ b/elf/dl-usage.c > @@ -22,6 +22,7 @@ > #include > #include "version.h" > > +#include > #include Right, I think that's what's missing. It's an oversight on my part. I tried build-many-glibcs.py on the whole series, but it doesn't have a configuration without tunables. Would you please post your patch to the list? You can also push it at the same time if you want, I think missing #includes are considered trivial under the check-in policy. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill