From: Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>
To: Raphael Moreira Zinsly <rzinsly@linux.ibm.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] powerpc: Protect dl_powerpc_cpu_features on INIT_ARCH() [BZ #26615]
Date: Tue, 22 Sep 2020 17:48:51 -0300 [thread overview]
Message-ID: <87h7rpo7v0.fsf@linux.ibm.com> (raw)
In-Reply-To: <20200914145924.11389-1-rzinsly@linux.ibm.com>
Raphael Moreira Zinsly <rzinsly@linux.ibm.com> writes:
> diff --git a/sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h b/sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h
> index 17ddfcf528..c8fa07fadc 100644
> --- a/sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h
> +++ b/sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h
> @@ -38,7 +38,7 @@
> unsigned long int hwcap = __GLRO(dl_hwcap); \
> unsigned long int __attribute__((unused)) hwcap2 = __GLRO(dl_hwcap2); \
> bool __attribute__((unused)) use_cached_memopt = \
> - GLRO(dl_powerpc_cpu_features).use_cached_memopt; \
> + __GLRO(dl_powerpc_cpu_features.use_cached_memopt); \
Agreed. LGTM.
This is fixing BZ #26615, which was created after you submitted this patch.
I added this information to the patch and pushed as 3322ecbfe2.
Thanks!
--
Tulio Magno
prev parent reply other threads:[~2020-09-22 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 14:59 [PATCH] powerpc: Protect dl_powerpc_cpu_features on INIT_ARCH() Raphael Moreira Zinsly
2020-09-22 20:48 ` Tulio Magno Quites Machado Filho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7rpo7v0.fsf@linux.ibm.com \
--to=tuliom@ascii.art.br \
--cc=libc-alpha@sourceware.org \
--cc=rzinsly@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).