* [PATCH] ckb_IQ locale: Add missing reorder-end keyword
@ 2020-04-28 9:58 Florian Weimer
2020-05-04 21:49 ` Rafal Luzynski
0 siblings, 1 reply; 6+ messages in thread
From: Florian Weimer @ 2020-04-28 9:58 UTC (permalink / raw)
To: libc-alpha
This suppresses a non-fatal error during locale building.
-----
localedata/locales/ckb_IQ | 2 ++
1 file changed, 2 insertions(+)
diff --git a/localedata/locales/ckb_IQ b/localedata/locales/ckb_IQ
index 238c381edf..ef2f3fcf2d 100644
--- a/localedata/locales/ckb_IQ
+++ b/localedata/locales/ckb_IQ
@@ -84,6 +84,8 @@ reorder-after <S0646> % ن
<S0648> % و
<S06C6> % ۆ
+reorder-end
+
END LC_COLLATE
LC_MONETARY
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ckb_IQ locale: Add missing reorder-end keyword
2020-04-28 9:58 [PATCH] ckb_IQ locale: Add missing reorder-end keyword Florian Weimer
@ 2020-05-04 21:49 ` Rafal Luzynski
2020-05-05 7:07 ` Florian Weimer
0 siblings, 1 reply; 6+ messages in thread
From: Rafal Luzynski @ 2020-05-04 21:49 UTC (permalink / raw)
To: Florian Weimer, libc-alpha
28.04.2020 11:58 Florian Weimer <fw@deneb.enyo.de> wrote:
>
> This suppresses a non-fatal error during locale building.
>
> -----
> localedata/locales/ckb_IQ | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/localedata/locales/ckb_IQ b/localedata/locales/ckb_IQ
> index 238c381edf..ef2f3fcf2d 100644
> --- a/localedata/locales/ckb_IQ
> +++ b/localedata/locales/ckb_IQ
> @@ -84,6 +84,8 @@ reorder-after <S0646> % ن
> <S0648> % و
> <S06C6> % ۆ
>
> +reorder-end
> +
> END LC_COLLATE
>
> LC_MONETARY
Thank you, Florian. Are you sure there are no more such cases, other
than these two (ckb_IQ and or_IN)?
Regards,
Rafal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ckb_IQ locale: Add missing reorder-end keyword
2020-05-04 21:49 ` Rafal Luzynski
@ 2020-05-05 7:07 ` Florian Weimer
2020-05-07 22:20 ` Rafal Luzynski
0 siblings, 1 reply; 6+ messages in thread
From: Florian Weimer @ 2020-05-05 7:07 UTC (permalink / raw)
To: Rafal Luzynski; +Cc: libc-alpha
* Rafal Luzynski:
> 28.04.2020 11:58 Florian Weimer <fw@deneb.enyo.de> wrote:
>>
>> This suppresses a non-fatal error during locale building.
>>
>> -----
>> localedata/locales/ckb_IQ | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/localedata/locales/ckb_IQ b/localedata/locales/ckb_IQ
>> index 238c381edf..ef2f3fcf2d 100644
>> --- a/localedata/locales/ckb_IQ
>> +++ b/localedata/locales/ckb_IQ
>> @@ -84,6 +84,8 @@ reorder-after <S0646> % ن
>> <S0648> % و
>> <S06C6> % ۆ
>>
>> +reorder-end
>> +
>> END LC_COLLATE
>>
>> LC_MONETARY
>
> Thank you, Florian. Are you sure there are no more such cases, other
> than these two (ckb_IQ and or_IN)?
I don't think so. I didn't see any other errors during the
install-locales command for the supported locales.
(The error should be fatal to the install operation, but that's a
different bug.)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ckb_IQ locale: Add missing reorder-end keyword
2020-05-05 7:07 ` Florian Weimer
@ 2020-05-07 22:20 ` Rafal Luzynski
2020-05-08 8:53 ` Florian Weimer
0 siblings, 1 reply; 6+ messages in thread
From: Rafal Luzynski @ 2020-05-07 22:20 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
5.05.2020 09:07 Florian Weimer <fw@deneb.enyo.de> wrote:
>
> * Rafal Luzynski:
>
> > [...]
> > Thank you, Florian. Are you sure there are no more such cases, other
> > than these two (ckb_IQ and or_IN)?
>
> I don't think so. I didn't see any other errors during the
> install-locales command for the supported locales.
It would be nice to have a command that would scan all locale source code
for missing reorder-end but nothing comes to my mind. It's not easy due
to possible include directive.
But better to fix those two bugs than to wait until we figure out how
to find all such bugs (while maybe there are no more).
No need to create a bugzilla ticket because this is not a user-visible bug.
My suggestion: please squash those two patches into one commit as they
are pretty trivial.
Both patches LGTM (no matter if you follow this suggestion or not).
Reviewed-by: Rafał Lużyński <digitalfreak@lingonborough.com>
Regards,
Rafal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ckb_IQ locale: Add missing reorder-end keyword
2020-05-07 22:20 ` Rafal Luzynski
@ 2020-05-08 8:53 ` Florian Weimer
2020-05-09 2:04 ` Carlos O'Donell
0 siblings, 1 reply; 6+ messages in thread
From: Florian Weimer @ 2020-05-08 8:53 UTC (permalink / raw)
To: Rafal Luzynski via Libc-alpha
* Rafal Luzynski via Libc-alpha:
> 5.05.2020 09:07 Florian Weimer <fw@deneb.enyo.de> wrote:
>>
>> * Rafal Luzynski:
>>
>> > [...]
>> > Thank you, Florian. Are you sure there are no more such cases, other
>> > than these two (ckb_IQ and or_IN)?
>>
>> I don't think so. I didn't see any other errors during the
>> install-locales command for the supported locales.
>
> It would be nice to have a command that would scan all locale source code
> for missing reorder-end but nothing comes to my mind. It's not easy due
> to possible include directive.
>
> But better to fix those two bugs than to wait until we figure out how
> to find all such bugs (while maybe there are no more).
>
> No need to create a bugzilla ticket because this is not a user-visible bug.
>
> My suggestion: please squash those two patches into one commit as they
> are pretty trivial.
>
> Both patches LGTM (no matter if you follow this suggestion or not).
>
> Reviewed-by: Rafał Lużyński <digitalfreak@lingonborough.com>
Thanks, I've squashed them together and committed them.
I know that Carlos is working on some localedef enhancements, maybe he
can slip in the error handling fix as well. 8-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ckb_IQ locale: Add missing reorder-end keyword
2020-05-08 8:53 ` Florian Weimer
@ 2020-05-09 2:04 ` Carlos O'Donell
0 siblings, 0 replies; 6+ messages in thread
From: Carlos O'Donell @ 2020-05-09 2:04 UTC (permalink / raw)
To: Florian Weimer, Rafal Luzynski via Libc-alpha
On 5/8/20 4:53 AM, Florian Weimer wrote:
> * Rafal Luzynski via Libc-alpha:
>
>> 5.05.2020 09:07 Florian Weimer <fw@deneb.enyo.de> wrote:
>>>
>>> * Rafal Luzynski:
>>>
>>>> [...]
>>>> Thank you, Florian. Are you sure there are no more such cases, other
>>>> than these two (ckb_IQ and or_IN)?
>>>
>>> I don't think so. I didn't see any other errors during the
>>> install-locales command for the supported locales.
>>
>> It would be nice to have a command that would scan all locale source code
>> for missing reorder-end but nothing comes to my mind. It's not easy due
>> to possible include directive.
>>
>> But better to fix those two bugs than to wait until we figure out how
>> to find all such bugs (while maybe there are no more).
>>
>> No need to create a bugzilla ticket because this is not a user-visible bug.
>>
>> My suggestion: please squash those two patches into one commit as they
>> are pretty trivial.
>>
>> Both patches LGTM (no matter if you follow this suggestion or not).
>>
>> Reviewed-by: Rafał Lużyński <digitalfreak@lingonborough.com>
>
> Thanks, I've squashed them together and committed them.
>
> I know that Carlos is working on some localedef enhancements, maybe he
> can slip in the error handling fix as well. 8-)
On my list to look at :-)
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-09 2:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 9:58 [PATCH] ckb_IQ locale: Add missing reorder-end keyword Florian Weimer
2020-05-04 21:49 ` Rafal Luzynski
2020-05-05 7:07 ` Florian Weimer
2020-05-07 22:20 ` Rafal Luzynski
2020-05-08 8:53 ` Florian Weimer
2020-05-09 2:04 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).