From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9987 invoked by alias); 13 Feb 2020 08:12:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 9845 invoked by uid 89); 13 Feb 2020 08:12:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*f:sk:xnh7zvc, H*i:sk:xnh7zvc X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581581537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0ej160kNE437RmJ9G3NnE4AdsvWERDGR9ACd9IHiUNY=; b=LQneztAXrMa7Y2CEi+i7SRj2slym69l/PKyK95RAZCcVgqI/qyHgzE6/g1Q9xNQLDBsunN f/9AIBhjnf9/Tq9J/98l8HTNq6Gbh7pEHmEaVW1HQitT1RSIesNFqAJ4JOEGcCx94NJL++ KgJ6MaV5S1kFheu5qzgpkYGxhSFP6qU= From: Florian Weimer To: DJ Delorie Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 6/7] nss_files: Use NSS_DECLARE_MODULE_FUNCTIONS References: Date: Thu, 13 Feb 2020 08:12:00 -0000 In-Reply-To: (DJ Delorie's message of "Wed, 12 Feb 2020 20:26:35 -0500") Message-ID: <87h7zudhyc.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-SW-Source: 2020-02/txt/msg00554.txt.bz2 * DJ Delorie: > Florian Weimer writes: >> nss/nss_files/files-alias.c | 2 ++ >> nss/nss_files/files-ethers.c | 3 +++ >> nss/nss_files/files-grp.c | 3 +++ >> nss/nss_files/files-hosts.c | 2 ++ >> nss/nss_files/files-init.c | 3 +++ >> nss/nss_files/files-initgroups.c | 3 +++ >> nss/nss_files/files-key.c | 2 ++ >> nss/nss_files/files-netgrp.c | 2 ++ >> nss/nss_files/files-network.c | 3 +++ >> nss/nss_files/files-proto.c | 2 ++ >> nss/nss_files/files-pwd.c | 3 +++ >> nss/nss_files/files-rpc.c | 2 ++ >> nss/nss_files/files-service.c | 2 ++ >> nss/nss_files/files-sgrp.c | 3 +++ >> nss/nss_files/files-spwd.c | 3 +++ >> 15 files changed, 38 insertions(+) > > LGTM. Seems to be some inconsistency about whether to use or > "nsswitch.h" - I wonder if always using "nsswitch.h" *just* for > consistency would be worth the cost? > > Reviewed-by: DJ Delorie Maybe we should add nss_files.h if there any common declarations? Thanks, Florian