From: Andreas Schwab <schwab@linux-m68k.org>
To: Zack Weinberg <zackw@panix.com>
Cc: libc-alpha@sourceware.org, fweimer@redhat.com,
adhemerval.zanella@linaro.org
Subject: Re: [PATCH 5/6] Remove miscellaneous debris from libio.
Date: Sun, 11 Feb 2018 18:39:00 -0000 [thread overview]
Message-ID: <87h8qnwgbg.fsf@linux-m68k.org> (raw)
In-Reply-To: <20180211163558.14124-6-zackw@panix.com> (Zack Weinberg's message of "Sun, 11 Feb 2018 11:35:57 -0500")
On Feb 11 2018, Zack Weinberg <zackw@panix.com> wrote:
> diff --git a/libio/fileops.c b/libio/fileops.c
> index fb39bec63cd..618c0d5c311 100644
> --- a/libio/fileops.c
> +++ b/libio/fileops.c
> @@ -468,11 +468,6 @@ int
> _IO_new_file_underflow (FILE *fp)
> {
> ssize_t count;
> -#if 0
> - /* SysV does not make this test; take it out for compatibility */
> - if (fp->_flags & _IO_EOF_SEEN)
> - return (EOF);
> -#endif
AFAICS, this is an area where we are not conforming to the C standard
(the EOF indicator is supposed to be sticking, see fgetc, and only
clearerr can fix that).
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2018-02-11 18:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 16:36 [PATCH 0/6] Mostly mechanical libio decrufting Zack Weinberg
2018-02-11 16:36 ` [PATCH 2/6] Mechanically remove _IO_ name aliases for types and constants Zack Weinberg
2018-02-11 17:57 ` Andreas Schwab
2018-02-11 16:36 ` [PATCH 6/6] Remove completely unused libio flag bits Zack Weinberg
2018-02-12 12:42 ` Adhemerval Zanella
2018-02-11 16:36 ` [PATCH 5/6] Remove miscellaneous debris from libio Zack Weinberg
2018-02-11 18:39 ` Andreas Schwab [this message]
2018-02-11 19:06 ` Zack Weinberg
2018-02-11 19:32 ` Andreas Schwab
2018-02-12 16:39 ` Joseph Myers
2018-02-12 16:44 ` Zack Weinberg
2018-02-19 19:12 ` Florian Weimer
2018-02-19 20:10 ` Zack Weinberg
2018-02-19 21:29 ` Florian Weimer
2018-02-20 0:18 ` Andreas Schwab
2018-02-20 10:26 ` Florian Weimer
2018-02-20 18:38 ` Andreas Schwab
2018-02-13 16:56 ` Zack Weinberg
2018-02-19 17:41 ` Florian Weimer
2018-02-21 21:25 ` Zack Weinberg
2018-02-21 23:24 ` Joseph Myers
2018-02-11 16:36 ` [PATCH 1/6] Remove vestiges of external build support from libio headers Zack Weinberg
2018-02-11 17:54 ` Andreas Schwab
2018-02-11 17:45 ` [PATCH 3/6] Remove legacy configuration knobs from libio Zack Weinberg
2018-02-11 18:07 ` Andreas Schwab
2018-02-12 11:41 ` Adhemerval Zanella
2018-02-11 17:52 ` [PATCH 4/6] Remove _IO_file_flags define Zack Weinberg
2018-02-11 18:20 ` Andreas Schwab
2018-02-21 21:25 ` [PATCH 0/6] Mostly mechanical libio decrufting Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8qnwgbg.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).