From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57952 invoked by alias); 13 Jun 2017 17:07:51 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 57941 invoked by uid 89); 13 Jun 2017 17:07:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com From: "Tulio Magno Quites Machado Filho" To: Alan Modra Cc: libc-alpha@sourceware.org Cc: Subject: Re: [PATCH 5/6] PowerPC64 ENTRY_TOCLESS In-Reply-To: <20170613144632.GH8406@bubble.grove.modra.org> References: <20170601130442.GF8842@bubble.grove.modra.org> <20170601131055.GK8842@bubble.grove.modra.org> <87o9tscc0f.fsf@linux.vnet.ibm.com> <20170613144632.GH8406@bubble.grove.modra.org> User-Agent: Notmuch/0.24.1 (http://notmuchmail.org) Emacs/25.2.1 (x86_64-redhat-linux-gnu) Date: Tue, 13 Jun 2017 17:07:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable x-cbid: 17061317-0020-0000-0000-000002B5130D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17061317-0021-0000-0000-000030D412E2 Message-Id: <87h8zjddem.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-13_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706130295 X-SW-Source: 2017-06/txt/msg00562.txt.bz2 Alan Modra writes: > On Tue, Jun 13, 2017 at 09:23:12AM -0300, Tulio Magno Quites Machado Filho wrote: >> Alan Modra writes: >> >> There are 2 more functions that could benefit from this optimization as well: >> - sysdeps/powerpc/fpu/s_fmaf.S >> - sysdeps/powerpc/fpu/s_fma.S >> >> Notice they're reused in powerpc32. > > I see. I hadn't looked for included files. This will mean modifying > powerpc32/sysdep.h to add > > #define ENTRY_TOCLESS(name) ENTRY(name) Looks good to me. >> > diff --git a/sysdeps/powerpc/powerpc64/power8/strcasestr.S b/sysdeps/powerpc/powerpc64/power8/strcasestr.S >> > index 6ac6572..3f59cb0 100644 >> > --- a/sysdeps/powerpc/powerpc64/power8/strcasestr.S >> > +++ b/sysdeps/powerpc/powerpc64/power8/strcasestr.S >> > @@ -85,7 +85,7 @@ >> > /* TODO: change this to .machine power8 when the minimum required binutils >> > allows it. */ >> > .machine power7 >> > -EALIGN (STRCASESTR, 4, 0) >> > +ENTRY (STRCASESTR, 4) >> > CALL_MCOUNT 2 >> > mflr r0 /* Load link register LR to r0. */ >> > std r31, -8(r1) /* Save callers register r31. */ >> >> >> Isn't it safe to use ENTRY_TOCLESS here too? > > No, the code uses @got@tprel(r2). Ack. Thanks! -- Tulio Magno