From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Remove CALL_THREAD_FCT macro
Date: Tue, 04 Apr 2017 19:22:00 -0000 [thread overview]
Message-ID: <87h924asg4.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <1491332713-10642-1-git-send-email-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Tue, 4 Apr 2017 16:05:13 -0300")
* Adhemerval Zanella:
> This patch removes CALL_THREAD_FCT macro usage and its defition for
> x86. For 32 bits it usage is only for force 16 stack alignment,
> however stack is already explicit aligned in clone syscall. For
> 64 bits and x32 it just a function call and there is no need to
> code it with inline assembly.
>
> Checked on i686-linux-gnu, x86_64-linux-gnu, and x86_64-linux-gnu-x32.
>
> * nptl/pthread_create.c (START_THREAD_DEFN): Remove
> CALL_THREAD_FCT macro usage.
> * sysdeps/i386/nptl/tls.h (CALL_THREAD_FCT): Remove definition.
> * sysdeps/x86_64/nptl/tls.h (CALL_THREAD_FCT): Likewise.
> * sysdeps/x86_64/32/nptl/tls.h: Remove file.
Looks good to me. Thanks.
prev parent reply other threads:[~2017-04-04 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 19:05 Adhemerval Zanella
2017-04-04 19:22 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h924asg4.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).