From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83908 invoked by alias); 28 Oct 2016 20:28:43 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 83831 invoked by uid 89); 28 Oct 2016 20:28:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=Hx-languages-length:762, 1026, held X-HELO: mx0a-001b2d01.pphosted.com From: "Tulio Magno Quites Machado Filho" To: Torvald Riegel Cc: libc-alpha@sourceware.org Cc: Subject: Re: [PATCH] Document a behavior of an elided pthread_rwlock_unlock In-Reply-To: <1477328930.7146.81.camel@localhost.localdomain> References: <1477083990-9983-1-git-send-email-tuliom@linux.vnet.ibm.com> <1477328930.7146.81.camel@localhost.localdomain> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.51.1 (x86_64-unknown-linux-gnu) Date: Fri, 28 Oct 2016 20:28:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16102820-1523-0000-0000-0000023FE758 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16102820-1524-0000-0000-0000298D07A8 Message-Id: <87h97wnrpu.fsf@totoro.br.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-28_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610280347 X-SW-Source: 2016-10/txt/msg00571.txt.bz2 Torvald Riegel writes: > On Fri, 2016-10-21 at 19:06 -0200, Tulio Magno Quites Machado Filho > wrote: >> diff --git a/sysdeps/powerpc/nptl/elide.h b/sysdeps/powerpc/nptl/elide.h >> index 77bd82e..c573981 100644 >> --- a/sysdeps/powerpc/nptl/elide.h >> +++ b/sysdeps/powerpc/nptl/elide.h >> @@ -102,6 +102,8 @@ __elide_unlock (int is_lock_free) >> { >> if (is_lock_free) >> { >> + /* Intentionally crashes when trying to unlock a lock not held by this >> + thread. */ > > I'd rather say that this can happen, and is okay (refering to the > comment in pthread_rwlock_unlock.c). Otherwise, LGTM. Good point. I'll make this change before pushing it. Thanks! -- Tulio Magno