From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113840 invoked by alias); 22 Sep 2016 20:34:06 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 113480 invoked by uid 89); 22 Sep 2016 20:34:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_40,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=_SYSCALL, _syscall, coded, Hx-languages-length:1228 X-HELO: albireo.enyo.de From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 1/4] Add INTERNAL_SYSCALL_CALL References: <1474383714-15187-1-git-send-email-adhemerval.zanella@linaro.org> <1474383714-15187-2-git-send-email-adhemerval.zanella@linaro.org> <87h99amey7.fsf@mid.deneb.enyo.de> <89560945-9ba0-395a-3829-bb0eae62affb@linaro.org> <87k2e5gir6.fsf@mid.deneb.enyo.de> Date: Thu, 22 Sep 2016 20:34:00 -0000 In-Reply-To: (Adhemerval Zanella's message of "Thu, 22 Sep 2016 10:42:55 -0300") Message-ID: <87h997znb9.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2016-09/txt/msg00467.txt.bz2 * Adhemerval Zanella: > We can, at least for x86_64 for instance where it uses another indirection > for INTERNAL_SYSCALL. However, something similar fails for i386, where > macro substitution for INTERNAL_SYSCALL will try string concatenation and > thus mess with intended behaviour. Also, _SYSCALL_NARGS macro would be > required to be different to take in consideration the 'err' argument > required for INTERNAL syscall (something I noted I coded wrong). > > I think calling the {INLINE,INTERNAL}_SYSCALL directly would be the safer > and agnostic approach to avoid issues on how they are actually implemented > by each port. Okay, it looks like this is the better way for now. > I tested the following patch with a build for practically all current > supported ports (aarch64, alpha, armeabi, armeaihf, hppa, ia64, i386, m68k, > microblaze, mips{32,64,n64}, nios2, powerpc{32,64,64le}, s390{-32,-64}, sh4, > sparc{64}, tile{pro,x64}, x86_64, and x32) and saw no build issues. I also > checked on x86_64 and i386. To actually check INTERNAL_SYSCALL_CALL macro > work I changed sysdeps/unix/sysv/linux/pthread_setaffinity.c to use it. Did you see object code changes from that?