From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] elf: Do not print the cache entry if --inhibit-cache is used
Date: Tue, 17 Oct 2023 21:30:58 +0200 [thread overview]
Message-ID: <87il75vyfh.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20231017145035.3741202-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Tue, 17 Oct 2023 11:50:35 -0300")
* Adhemerval Zanella:
> So --help informs the correct shared library search path.
> ---
> elf/dl-usage.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/elf/dl-usage.c b/elf/dl-usage.c
> index 98f0b0d027..04315451f2 100644
> --- a/elf/dl-usage.c
> +++ b/elf/dl-usage.c
> @@ -99,7 +99,8 @@ print_search_path_for_help (struct dl_main_state *state)
> if (map != NULL)
> print_search_path_for_help_1 (map->l_runpath_dirs.dirs);
>
> - _dl_printf (" (libraries located via %s)\n", LD_SO_CACHE);
> + if (!GLRO(dl_inhibit_cache))
> + _dl_printf (" (libraries located via %s)\n", LD_SO_CACHE);
>
> print_search_path_for_help_1 (__rtld_search_dirs.dirs);
> }
Good idea, thanks.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Florian
prev parent reply other threads:[~2023-10-17 19:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 14:50 Adhemerval Zanella
2023-10-17 19:30 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il75vyfh.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).