From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9A6533858D33 for ; Tue, 17 Oct 2023 19:31:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A6533858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A6533858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697571070; cv=none; b=KFTepEqEW6Wh+/Nx9haVyB1tJ47UyrrHoG6tBVhywsxio1RrO/A5cAXwRRvKIgtAHH7prBrc8l9bYiONOYaz60ZAMnV9VA/gZPDP7lb6Xr6Q6qtkPWkbMqCN2TRg2rADUp7/MOg7l89fe8uyEKPLk/PMlBYbyr58kAtAe+rBBlQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697571070; c=relaxed/simple; bh=1xcoB8cwlw3gX2oBDLDZlKwUT71OPYDPhtPK7RoSxBk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Q9kHtw1rNqcxh/9hKGyl9fWJM+qGwBJNUK21AioRGHI/NUaL0kTFLDGJrVSwsHXUrm+lpzsxmazYWnI0xA3zdK6cFPxRCA5wBWNP0Xf3VNHL5zbnv8GAvzF7GSosOoWxZuCABsZLA83RhTLfNzOzNVuqr0lRaF153vZmfP9WyGo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697571069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qc9XSPOyvgPpKc/QoETxINm/MGwQQWmzjM/KeAo2oQw=; b=N707ISA8vBJYvQkEmhvqb86wP7rcoHa8Anx26+eSbhc1ifTWX2OTPSXKCkXyaYt/+iuZwM Iplspiw8yBKHB/fJmIq3EIw5rgm8GnkkKGjgKxtc4bv6MgzrqRuELId5w77Qn6k8W92UuG 5XyaQdXWBo5kagFB3YVSwAy+B/3UN+0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-611-lwlbd58lPOmkQlQVv1pJ4A-1; Tue, 17 Oct 2023 15:31:00 -0400 X-MC-Unique: lwlbd58lPOmkQlQVv1pJ4A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6C50B1029F46; Tue, 17 Oct 2023 19:31:00 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC30825C8; Tue, 17 Oct 2023 19:30:59 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] elf: Do not print the cache entry if --inhibit-cache is used References: <20231017145035.3741202-1-adhemerval.zanella@linaro.org> Date: Tue, 17 Oct 2023 21:30:58 +0200 In-Reply-To: <20231017145035.3741202-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Tue, 17 Oct 2023 11:50:35 -0300") Message-ID: <87il75vyfh.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella: > So --help informs the correct shared library search path. > --- > elf/dl-usage.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/elf/dl-usage.c b/elf/dl-usage.c > index 98f0b0d027..04315451f2 100644 > --- a/elf/dl-usage.c > +++ b/elf/dl-usage.c > @@ -99,7 +99,8 @@ print_search_path_for_help (struct dl_main_state *state) > if (map != NULL) > print_search_path_for_help_1 (map->l_runpath_dirs.dirs); > > - _dl_printf (" (libraries located via %s)\n", LD_SO_CACHE); > + if (!GLRO(dl_inhibit_cache)) > + _dl_printf (" (libraries located via %s)\n", LD_SO_CACHE); > > print_search_path_for_help_1 (__rtld_search_dirs.dirs); > } Good idea, thanks. Reviewed-by: Florian Weimer Florian