From: Florian Weimer <fweimer@redhat.com>
To: Colin Leroy-Mira via Libc-alpha <libc-alpha@sourceware.org>
Cc: Colin Leroy-Mira <colin@colino.net>
Subject: Re: [PATCH v3] localedata: Translit common emojis to smileys [BZ #30649]
Date: Mon, 28 Aug 2023 15:10:55 +0200 [thread overview]
Message-ID: <87il8zuxb4.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230808135256.1967277-1-colin@colino.net> (Colin Leroy-Mira via Libc-alpha's message of "Tue, 8 Aug 2023 15:52:56 +0200")
* Colin Leroy-Mira via Libc-alpha:
> Add common emojis to the translit-able characters (mostly
> faces and hearts), and translit them to old-fashioned
> smileys.
>
> Author: Colin Leroy-Mira <colin@colino.net>
> Signed-off-by: Colin Leroy-Mira <colin@colino.net>
Looks good overall.
As you do not have copyright assignment and contribute under DCO,
please post a v4 with
+ Copyright The GNU Toolchain Authors.
added in localedata/Makefile and localedata/tst-iconv-emojis-trans.c.
(I assume yoy copied the latter from another test file, which is why
copyright starts in 2019).
Thanks,
Florian
next prev parent reply other threads:[~2023-08-28 13:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 16:17 [PATCH] " Colin Leroy-Mira
2023-07-20 22:27 ` [PATCH][v2] " Colin Leroy-Mira
2023-07-21 14:11 ` [PATCH v2] " Colin Leroy-Mira
2023-08-08 7:07 ` Colin Leroy-Mira
2023-08-08 9:20 ` Florian Weimer
2023-08-08 10:02 ` Colin Leroy-Mira
2023-08-08 11:50 ` Florian Weimer
2023-08-08 13:52 ` [PATCH v3] " Colin Leroy-Mira
2023-08-16 8:33 ` [PING] " Colin Leroy-Mira
2023-08-23 17:42 ` [ping] " Colin Leroy-Mira
2023-08-28 13:10 ` Florian Weimer [this message]
2023-08-29 6:02 ` [PATCH v4] " Colin Leroy-Mira
2023-08-29 7:26 ` Florian Weimer
2023-08-29 7:50 ` Colin Leroy-Mira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il8zuxb4.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=colin@colino.net \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).