From: Florian Weimer <fw@deneb.enyo.de>
To: Andreas Schwab via Libc-alpha <libc-alpha@sourceware.org>
Cc: Andreas Schwab <schwab@suse.de>
Subject: Re: [PATCH] dlopen: skip debugger notification for DSO loaded from sprof (bug 30258)
Date: Fri, 24 Mar 2023 12:18:59 +0100 [thread overview]
Message-ID: <87ileq2y8s.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <mvm355vwhpx.fsf@suse.de> (Andreas Schwab via Libc-alpha's message of "Thu, 23 Mar 2023 17:33:14 +0100")
* Andreas Schwab via Libc-alpha:
> Avoid inconsistent state in the debugger interface.
> ---
> elf/dl-load.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/elf/dl-load.c b/elf/dl-load.c
> index 9a0e40c0e9..39c63ff1b3 100644
> --- a/elf/dl-load.c
> +++ b/elf/dl-load.c
> @@ -1483,6 +1483,10 @@ cannot enable executable stack as shared object requires");
> /* Now that the object is fully initialized add it to the object list. */
> _dl_add_to_namespace_list (l, nsid);
>
> + /* Skip auditing and debugger notification when called from 'sprof'. */
> + if (mode & __RTLD_SPROF)
> + return l;
> +
> /* Signal that we are going to add new objects. */
> struct r_debug *r = _dl_debug_update (nsid);
> if (r->r_state == RT_CONSISTENT)
Can we add a test for this? Thanks.
next prev parent reply other threads:[~2023-03-24 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 16:33 Andreas Schwab
2023-03-24 11:18 ` Florian Weimer [this message]
2023-05-08 14:08 Andreas Schwab
2023-05-08 16:04 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ileq2y8s.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).