From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=qunE=6R=redhat.com=fweimer@sourceware.org>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	by sourceware.org (Postfix) with ESMTPS id 6F0BA3858C83
	for <libc-alpha@sourceware.org>; Tue, 21 Feb 2023 10:15:02 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F0BA3858C83
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1676974502;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type;
	bh=ZmsLCxFgElYiBO6YkA0x28JNzKt6sLGTUbV/dHqBUJ4=;
	b=c05DfjsCaRKRP6VMbIK5c2zvaJIRm5nHk9ixTCM3/9Td1u5sfLoLczU1XGAbtu/0ym6SYn
	YBfXxzd0SscpgzAUvDf+6R4QdOiu5ymcGGcaU2g5lBUgO2j26uNqoX9CFzTuz2NjutyKiH
	wcwet3OkO42hOtAwNTrqfWuSZK2pYko=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-467-cl2hTsT-PPelpPAVYvCurA-1; Tue, 21 Feb 2023 05:15:00 -0500
X-MC-Unique: cl2hTsT-PPelpPAVYvCurA-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 49B98101A521;
	Tue, 21 Feb 2023 10:15:00 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.2.16.5])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id A5F25440DE;
	Tue, 21 Feb 2023 10:14:59 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org, bug-gnulib@gnu.org
Cc: Sachin Monga <smonga@linux.ibm.com>
Subject: Updating <sys/cdefs.h> in glibc and gnulib
Date: Tue, 21 Feb 2023 11:14:57 +0100
Message-ID: <87ilfvqq8u.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

Why does gnulib bundle <sys/cdefs.h>?  We edit this file regularly in
glibc.  In the past, some gnulib-using programs supplied their own copy
of <sys/cdefs.h> instead, even when building against glibc.  This caused
build failures in the glibc headers because they (quite reasonably)
assumed that <sys/cdefs.h> defines the macros for that glibc version.

Does gnulib still override <sys/cdefs.h> unconditionally?

A version check will be difficult because sometimes, we have to backport
header fixes to older versions, and that may require adding additional
macros in <sys/cdefs.h>.

We could move glibc's internal definitions to a new header, reducing
<sys/cdefs.h> in scope, but presumably that means gnulib would just
starting bundling that other header, and we would have the same issue
once more.

Thanks,
Florian