From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id ECEE638582A3 for ; Mon, 2 Jan 2023 11:45:01 +0000 (GMT) Received: from frontend03.mail.m-online.net (unknown [192.168.6.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4NlvDX6t92z1sBQy; Mon, 2 Jan 2023 12:45:00 +0100 (CET) Received: from localhost (dynscan3.mnet-online.de [192.168.6.84]) by mail.m-online.net (Postfix) with ESMTP id 4NlvDX6fq1z1qqlR; Mon, 2 Jan 2023 12:45:00 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new, port 10024) with ESMTP id UEcQecDudQZ6; Mon, 2 Jan 2023 12:45:00 +0100 (CET) X-Auth-Info: IFrCwFMlo4vOGIyGdScIC+3yYhN3bxahiwrWN35pg3VfjR/IKrC4goXIJouH7kPH Received: from igel.home (aftr-62-216-205-97.dynamic.mnet-online.de [62.216.205.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 2 Jan 2023 12:45:00 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id E6EF72C129C; Mon, 2 Jan 2023 12:44:59 +0100 (CET) From: Andreas Schwab To: Florian Weimer via Libc-alpha Cc: Florian Weimer Subject: Re: [PATCH] time: Set daylight to 1 for matching DST/offset change (bug 29951) References: <871qodqj56.fsf@oldenburg.str.redhat.com> X-Yow: I am having FUN... I wonder if it's NET FUN or GROSS FUN? Date: Mon, 02 Jan 2023 12:44:59 +0100 In-Reply-To: <871qodqj56.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Mon, 02 Jan 2023 12:18:45 +0100") Message-ID: <87ilhpp3d0.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jan 02 2023, Florian Weimer via Libc-alpha wrote: > + /* Keep searching to seet if there is a DST rule. This s/seet/see/ > + /* Check that localtime re-initializes the two variables. */ > + daylight = timezone = 17; > + time_t t = 844034401; > + struct tm *tm = localtime (&t); > + TEST_COMPARE (daylight, 1); The manual documents only a non-zero value. > + TEST_COMPARE (daylight, 1); > + TEST_COMPARE (timezone, -7200); Duplicate tests. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."