From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	by sourceware.org (Postfix) with ESMTPS id 19222384F033
	for <libc-alpha@sourceware.org>; Thu, 10 Nov 2022 10:39:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 19222384F033
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1668076771;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=9vGr1PuK02kOI1eud1xypzLOa5PqUYI24Aoxan/WFbk=;
	b=Oa4Q3Jfuxc1aLoszRyxJWtCy2pFUzdAUZJPH7nne7KSiFPfPetsvo1gBIcgPqesbiq6dg5
	VMv7AUgzyQW/QTSoFXl4DTh0IVwOgy7z7risb7wrJg0V1ZaoNBAc3n1ohlihvQXyzXdyfo
	XmqfouxNA5TxY3ReMOzuc5IQNLndQCU=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-435--LXsuMLxMDiVBbFSqlIBow-1; Thu, 10 Nov 2022 05:39:30 -0500
X-MC-Unique: -LXsuMLxMDiVBbFSqlIBow-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 284402833B20
	for <libc-alpha@sourceware.org>; Thu, 10 Nov 2022 10:39:30 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.193.5])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 8C4E7C1908A
	for <libc-alpha@sourceware.org>; Thu, 10 Nov 2022 10:39:29 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Linux: Support __IPC_64 in sysvctl *ctl command arguments
References: <87bkphij87.fsf@oldenburg.str.redhat.com>
Date: Thu, 10 Nov 2022 11:39:27 +0100
In-Reply-To: <87bkphij87.fsf@oldenburg.str.redhat.com> (Florian Weimer via
	Libc-alpha's message of "Tue, 08 Nov 2022 16:00:56 +0100")
Message-ID: <87iljnum8w.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Florian Weimer via Libc-alpha:

> Old applications pass __IPC_64 as part of the command argument because
> old glibc did not check for unknown commands, and passed through the
> arguments directly to the kernel, without adding __IPC_64.
> Applications need to continue doing that for old glibc compatibility,
> so this commit enables this approach in current glibc.
>
> For msgctl and shmctl, if no translation is required, make
> direct system calls, as we did before the time64 changes.  If
> translation is required, mask __IPC_64 from the command argument.
>
> For semctl, the union-in-vararg argument handling means that
> translation is needed on all architectures.
>
> Tested on i686-linux-gnu, powerpc64le-linux-gnu, x86_64-linux-gnu.
> Built with build-many-glibcs.py.

I've filed a bug:

  Restore IPC_64 support in sysvipc *ctl functions
  <https://sourceware.org/bugzilla/show_bug.cgi?id=29771>

I'm going to reference it in the commit message.

Thanks,
Florian