From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@deneb.enyo.de>
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
	by sourceware.org (Postfix) with ESMTPS id 3685E3858D1E
	for <libc-alpha@sourceware.org>; Fri, 30 Sep 2022 09:57:38 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3685E3858D1E
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=deneb.enyo.de
Received: from [172.17.203.2] (port=55035 helo=deneb.enyo.de)
	by albireo.enyo.de ([172.17.140.2]) with esmtps (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
	id 1oeClz-008bBc-Nx; Fri, 30 Sep 2022 09:57:35 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.94.2)
	(envelope-from <fw@deneb.enyo.de>)
	id 1oeClz-000AEt-E1; Fri, 30 Sep 2022 11:57:35 +0200
From: Florian Weimer <fw@deneb.enyo.de>
To: Yu Chien Peter Lin <peterlin@andestech.com>
Cc: <libc-alpha@sourceware.org>,  <alankao@andestech.com>,
  <ycliang@andestech.com>,  <dylan@andestech.com>
Subject: Re: [PATCH] nptl: Convert tst-setuid2 to test-driver
References: <20220930064300.22758-1-peterlin@andestech.com>
Date: Fri, 30 Sep 2022 11:57:35 +0200
In-Reply-To: <20220930064300.22758-1-peterlin@andestech.com> (Yu Chien Peter
	Lin's message of "Fri, 30 Sep 2022 14:43:00 +0800")
Message-ID: <87ill5p4kw.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Yu Chien Peter Lin:

> diff --git a/support/Makefile b/support/Makefile
> index 551d02941f..4046b12fbd 100644
> --- a/support/Makefile
> +++ b/support/Makefile
> @@ -159,6 +159,7 @@ libsupport-routines = \
>    xpthread_cancel \
>    xpthread_check_return \
>    xpthread_cond_wait \
> +  xpthread_cond_signal \
>    xpthread_create \
>    xpthread_detach \
>    xpthread_join \
> diff --git a/support/xpthread_cond_signal.c b/support/xpthread_cond_signal.c
> new file mode 100644
> index 0000000000..51d04d2a66
> --- /dev/null
> +++ b/support/xpthread_cond_signal.c
> @@ -0,0 +1,26 @@
> +/* pthread_cond_signal with error checking.
> +   Copyright (C) 2016-2022 Free Software Foundation, Inc.

Copyright year should be 2022.

Could you put the support/ changes into a separate patch?  Rest looks
good.