From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 86B1B3858D28 for ; Thu, 21 Jul 2022 13:26:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 86B1B3858D28 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-145-s_hu7tU7MqGQatxFjbcZKw-1; Thu, 21 Jul 2022 09:26:14 -0400 X-MC-Unique: s_hu7tU7MqGQatxFjbcZKw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EDA4F185A7B2; Thu, 21 Jul 2022 13:26:13 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 21FD82166B26; Thu, 21 Jul 2022 13:26:12 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] malloc: Simplify implementation of __malloc_assert References: <87a6924uvf.fsf@oldenburg.str.redhat.com> <21e64150-606d-df60-e50f-df09ca5a67ff@linaro.org> Date: Thu, 21 Jul 2022 15:26:11 +0200 In-Reply-To: <21e64150-606d-df60-e50f-df09ca5a67ff@linaro.org> (Adhemerval Zanella Netto's message of "Thu, 21 Jul 2022 10:10:25 -0300") Message-ID: <87ilnq38cs.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 13:26:18 -0000 * Adhemerval Zanella Netto: >> + __libc_message (do_abort, "\ >> +Fatal glibc error: malloc assertion failure in %s: %s\n", >> + function, assertion); >> + __builtin_unreachable (); >> } >> #endif >> #endif >> > > Would be better to keep the the file and line information? I would have to figure out how to use _itoa correctly. 8-/ I think we converted almost all asserts that are reachable through heap corruption into malloc_printerr a couple of years ago, so the diagnostic value of the line number will be really low. That's why I had to resort to GDB to test this. Do you insist that I add file and line number information? Thanks, Florian