From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C42683858C53 for ; Wed, 4 May 2022 17:11:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C42683858C53 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-422-oBk0LS8QP9iEEKd6l3RHPg-1; Wed, 04 May 2022 13:11:05 -0400 X-MC-Unique: oBk0LS8QP9iEEKd6l3RHPg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C37483C977C1; Wed, 4 May 2022 17:11:04 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E9E7E15699FA; Wed, 4 May 2022 17:11:03 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 1/3] ia64: Always define IA64_USE_NEW_STUB as a flag macro References: <49a7f4d3-81db-eee6-bd40-ef5ad225d63c@linaro.org> Date: Wed, 04 May 2022 19:11:02 +0200 In-Reply-To: <49a7f4d3-81db-eee6-bd40-ef5ad225d63c@linaro.org> (Adhemerval Zanella's message of "Wed, 4 May 2022 13:54:47 -0300") Message-ID: <87ilqlp6jd.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 17:11:08 -0000 * Adhemerval Zanella: > On 04/05/2022 13:47, Florian Weimer wrote: >> And keep the previous definition if it exists. This allows >> disabling IA64_USE_NEW_STUB while keeping USE_DL_SYSINFO defined. >> --- >> v2: New patch. >> sysdeps/unix/sysv/linux/ia64/brk.c | 3 +-- >> sysdeps/unix/sysv/linux/ia64/sysdep.h | 21 +++++++++++++-------- >> 2 files changed, 14 insertions(+), 10 deletions(-) >> >> diff --git a/sysdeps/unix/sysv/linux/ia64/brk.c b/sysdeps/unix/sysv/linux/ia64/brk.c >> index 65142aeae9..e1fa88f9b0 100644 >> --- a/sysdeps/unix/sysv/linux/ia64/brk.c >> +++ b/sysdeps/unix/sysv/linux/ia64/brk.c >> @@ -16,7 +16,6 @@ >> License along with the GNU C Library; if not, see >> . */ >> >> -#include >> /* brk is used by statup before TCB is properly set. */ >> -#undef USE_DL_SYSINFO >> +#define IA64_USE_NEW_STUB 0 >> #include >> diff --git a/sysdeps/unix/sysv/linux/ia64/sysdep.h b/sysdeps/unix/sysv/linux/ia64/sysdep.h >> index 193ecee023..72b72acb6f 100644 >> --- a/sysdeps/unix/sysv/linux/ia64/sysdep.h >> +++ b/sysdeps/unix/sysv/linux/ia64/sysdep.h >> @@ -44,12 +44,17 @@ >> #undef SYS_ify >> #define SYS_ify(syscall_name) __NR_##syscall_name >> >> -#if defined USE_DL_SYSINFO \ >> +#ifndef IA64_USE_NEW_STUB >> +# if defined USE_DL_SYSINFO \ >> && (IS_IN (libc) \ >> || IS_IN (libpthread) || IS_IN (librt)) > > I think you can drop libpthread and librt here. Will do so in v3. Thanks, Florian