From: Florian Weimer <fweimer@redhat.com>
To: Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org>
Cc: Szabolcs Nagy <szabolcs.nagy@arm.com>
Subject: Re: [PATCH 1/3] Remove _dl_skip_args_internal declaration
Date: Tue, 12 Apr 2022 15:40:28 +0200 [thread overview]
Message-ID: <87ilre773n.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <ee142507fe416492b087df65a77ef33e05936082.1649767418.git.szabolcs.nagy@arm.com> (Szabolcs Nagy via Libc-alpha's message of "Tue, 12 Apr 2022 13:55:19 +0100")
* Szabolcs Nagy via Libc-alpha:
> It does not seem to be used.
> ---
> sysdeps/generic/ldsodefs.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h
> index 44750461a9..29f005499b 100644
> --- a/sysdeps/generic/ldsodefs.h
> +++ b/sysdeps/generic/ldsodefs.h
> @@ -781,11 +781,6 @@ extern char **_dl_argv
> rtld_hidden_proto (_dl_argv)
> #if IS_IN (rtld)
> extern unsigned int _dl_skip_args attribute_hidden
> -# ifndef DL_ARGV_NOT_RELRO
> - attribute_relro
> -# endif
> - ;
> -extern unsigned int _dl_skip_args_internal attribute_hidden
> # ifndef DL_ARGV_NOT_RELRO
> attribute_relro
> # endif
Looks okay.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
next prev parent reply other threads:[~2022-04-12 13:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 12:55 [PATCH 0/3] Args adjustment with ./ld.so exe [BZ #23293] Szabolcs Nagy
2022-04-12 12:55 ` [PATCH 1/3] Remove _dl_skip_args_internal declaration Szabolcs Nagy
2022-04-12 13:40 ` Florian Weimer [this message]
2022-04-12 13:51 ` Andreas Schwab
2022-04-12 12:55 ` [PATCH 2/3] aarch64: Use generic argv adjustment in ld.so [BZ #23293] Szabolcs Nagy
2022-04-12 14:12 ` Florian Weimer
2022-04-12 14:25 ` Florian Weimer
2022-04-13 8:09 ` Szabolcs Nagy
2022-04-12 12:55 ` [PATCH 3/3] aarch64: Move ld.so _start to separate file Szabolcs Nagy
2022-04-12 14:11 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilre773n.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).