From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1A39C385840A for ; Mon, 14 Feb 2022 10:10:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1A39C385840A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-562-KagOs1XJOQi6aH4Osiy0oA-1; Mon, 14 Feb 2022 05:10:49 -0500 X-MC-Unique: KagOs1XJOQi6aH4Osiy0oA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 056CF1808327; Mon, 14 Feb 2022 10:10:49 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.195.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CE547B6F0; Mon, 14 Feb 2022 10:10:48 +0000 (UTC) From: Florian Weimer To: Szabolcs Nagy Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Linux: Consolidate auxiliary vector parsing (redo) References: <87y22hqh2w.fsf@oldenburg.str.redhat.com> <20220214082751.GF2692478@arm.com> Date: Mon, 14 Feb 2022 11:10:45 +0100 In-Reply-To: <20220214082751.GF2692478@arm.com> (Szabolcs Nagy's message of "Mon, 14 Feb 2022 08:27:51 +0000") Message-ID: <87ilth69ne.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2022 10:10:54 -0000 * Szabolcs Nagy: > The 02/11/2022 21:33, Florian Weimer via Libc-alpha wrote: >> And optimize it slightly. >> >> This is commit 8c8510ab2790039e58995ef3a22309582413d3ff revised. >> >> In _dl_aux_init in elf/dl-support.c, use an explicit loop >> and -fno-tree-loop-distribute-patterns to avoid memset. >> >> Tested on aarch64-linux-gnu, i686-linux-gnu, x86_64-linux-gnu. >> Built with build-many-glibcs.py. > > thanks, this looks good. > > Reviewed-by: Szabolcs Nagy Thanks. I'll push a slightly changed version which reorders the included header files in sysdeps/unix/sysv/linux/dl-sysdep.c because this seems to be required to address an s390x build failure in some configurations. Florian