public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Fix DFS sorting algorithm for LD_TRACE_LOADED_OBJECTS with missing libraries (BZ #28868)
Date: Tue, 08 Feb 2022 23:51:18 +0100	[thread overview]
Message-ID: <87iltp3rbt.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220208183639.2262680-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 8 Feb 2022 15:36:39 -0300")

* Adhemerval Zanella via Libc-alpha:

> diff --git a/elf/dl-sort-maps.c b/elf/dl-sort-maps.c
> index 9e9d53ec47..f049178ac3 100644
> --- a/elf/dl-sort-maps.c
> +++ b/elf/dl-sort-maps.c
> @@ -140,7 +140,7 @@ static void
>  dfs_traversal (struct link_map ***rpo, struct link_map *map,
>  	       bool *do_reldeps)
>  {
> -  if (map->l_visited)
> +  if (map->l_visited || map->l_faked)
>      return;
>  
>    map->l_visited = 1;

Sorry, not a full review, but please add a comment why map->l_faked is
needed, referencing _dl_map_object_deps and the l_fake filtering there,
and perhaps also add a comment referencing dfs_traversal in the l_fake
filtering.

Thanks,
Florian


  parent reply	other threads:[~2022-02-08 22:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 18:36 Adhemerval Zanella
2022-02-08 22:48 ` Dmitry V. Levin
2022-02-08 22:56   ` Adhemerval Zanella
2022-02-09 12:15     ` Adhemerval Zanella
2022-02-08 22:51 ` Florian Weimer [this message]
2022-02-08 22:56   ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iltp3rbt.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).