From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTPS id C7DC83858410
 for <libc-alpha@sourceware.org>; Mon, 25 Oct 2021 13:54:39 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C7DC83858410
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-520-B-H_wMLKOgi5_KhTAFi8kA-1; Mon, 25 Oct 2021 09:54:35 -0400
X-MC-Unique: B-H_wMLKOgi5_KhTAFi8kA-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1CB0B10A8E0A;
 Mon, 25 Oct 2021 13:54:35 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.194.250])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 5CA945D9D5;
 Mon, 25 Oct 2021 13:54:34 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Make global.out depend on reldepmod4.so [BZ #28457]
References: <20211015182924.1028229-1-hjl.tools@gmail.com>
Date: Mon, 25 Oct 2021 15:54:32 +0200
In-Reply-To: <20211015182924.1028229-1-hjl.tools@gmail.com> (H. J. Lu via
 Libc-alpha's message of "Fri, 15 Oct 2021 11:29:24 -0700")
Message-ID: <87ilxltdk7.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
 RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Oct 2021 13:54:41 -0000

* H. J. Lu via Libc-alpha:

> The global test is linked with globalmod1.so which dlopens reldepmod4.so.
> Make global.out depend on reldepmod4.so.  This fixes BZ #28457.
> ---
>  elf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elf/Makefile b/elf/Makefile
> index bf45d8ee24..b01ace2d5a 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -976,7 +976,7 @@ $(objpfx)tst-rtld-preload.out: tst-rtld-preload.sh $(objpfx)ld.so \
>  $(objpfx)initfirst.out: $(objpfx)firstobj.so
>  
>  $(objpfx)global: $(objpfx)globalmod1.so
> -$(objpfx)global.out: $(objpfx)reldepmod1.so
> +$(objpfx)global.out: $(objpfx)reldepmod1.so $(objpfx)reldepmod4.so
>  
>  $(objpfx)dblload.out: $(objpfx)dblloadmod1.so $(objpfx)dblloadmod2.so

Looks okay.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian