From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>
Cc: Siddhesh Poyarekar <siddhesh@sourceware.org>
Subject: Re: [PATCH] elf/tests: Make thrlock and noload depend on libm
Date: Wed, 07 Jul 2021 19:06:09 +0200 [thread overview]
Message-ID: <87im1m2gvy.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210707165859.2993732-1-siddhesh@sourceware.org> (Siddhesh Poyarekar via Libc-alpha's message of "Wed, 7 Jul 2021 22:28:59 +0530")
* Siddhesh Poyarekar via Libc-alpha:
> Both tests try to dlopen libm.so at runtime, so make them depend on it
> to avoid running before libm.so is built.
Can that really happen in the current build system?
It's still value to re-run the tests after libm has changed, so the
patch looks okay to me (only the justification is lacking).
Thanks,
Florian
next prev parent reply other threads:[~2021-07-07 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 16:58 Siddhesh Poyarekar
2021-07-07 17:06 ` Florian Weimer [this message]
2021-07-07 17:22 ` Siddhesh Poyarekar
2021-07-08 5:46 ` Florian Weimer
2021-07-08 6:01 ` Siddhesh Poyarekar
2021-07-08 6:09 ` Florian Weimer
2021-07-08 6:12 ` Siddhesh Poyarekar
2021-07-08 6:15 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im1m2gvy.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).