From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 20ECC3851C0D for ; Tue, 4 May 2021 21:46:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 20ECC3851C0D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-556-yLpz41oZMVST5ppZz3_Cww-1; Tue, 04 May 2021 17:46:05 -0400 X-MC-Unique: yLpz41oZMVST5ppZz3_Cww-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 492AC107ACE6; Tue, 4 May 2021 21:46:04 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-137.ams2.redhat.com [10.36.112.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BD555944F; Tue, 4 May 2021 21:45:58 +0000 (UTC) From: Florian Weimer To: Carlos O'Donell Cc: libc-alpha@sourceware.org, joseph@codesourcery.com Subject: Re: [PATCH] Make Unicode generation reproducible. References: <20210429172742.3301414-1-carlos@redhat.com> <87wnsk86nx.fsf@oldenburg.str.redhat.com> Date: Tue, 04 May 2021 23:46:13 +0200 In-Reply-To: <87wnsk86nx.fsf@oldenburg.str.redhat.com> (Florian Weimer's message of "Fri, 30 Apr 2021 11:26:26 +0200") Message-ID: <87im3ygoka.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 May 2021 21:46:08 -0000 * Florian Weimer: > * Carlos O'Donell: > >> diff --git a/localedata/unicode-gen/UnicodeRelease.txt b/localedata/unicode-gen/UnicodeRelease.txt >> new file mode 100644 >> index 0000000000..bd9cc14ae0 >> --- /dev/null >> +++ b/localedata/unicode-gen/UnicodeRelease.txt >> @@ -0,0 +1,8 @@ >> +% This metadata is used by glibc and updated by the developer(s) >> +% carrying out the Unicode update. >> +Version,13.0.0 >> +ReleaseDate,2021-03-10 >> +Data,UnicodeData.txt >> +DcpData,DerivedCoreProperties.txt >> +EawData,EastAsianWidth.txt >> +PlData,PropList.txt > > I suggest to use > instead. It would give 2020-03-06 as the date. 2021-03-10 is > definitely wrong, it should be 2020-03-10. > > Perhaps it's time to move the *.txt files into their own directory and > also include and > . Hmm, maybe this is asking for too much, given that this started out as something else entirely. Maybe put variables into the generator script along with a comment for now? I think the custom descriptor file is probably a bit overdesigned. Thanks, Florian