Re: [PATCH] Add RFC 8335 Definitions from Linux 5.12

[Florian Weimer <fweimer@redhat.com>]

* Andreas Roeseler via Libc-alpha:

> diff --git a/sysdeps/gnu/netinet/ip_icmp.h b/sysdeps/gnu/netinet/ip_icmp.h
> index 5db7ac7c37..1fd6317df4 100644
> --- a/sysdeps/gnu/netinet/ip_icmp.h
> +++ b/sysdeps/gnu/netinet/ip_icmp.h
> @@ -89,6 +89,23 @@ struct icmphdr
>  #define ICMP_EXC_TTL		0	/* TTL count exceeded		*/
>  #define ICMP_EXC_FRAGTIME	1	/* Fragment Reass time exceeded	*/
>  
> +/* Codes for EXT_ECHO (PROBE) */
> +#define ICMP_EXT_ECHO		42
> +#define ICMP_EXT_ECHOREPLY	43
> +#define ICMP_EXT_MAL_QUERY	1	/* Malformed Query */
> +#define ICMP_EXT_NO_IF		2	/* No such Interface */
> +#define ICMP_EXT_NO_TABLE_ENT	3	/* No such Table Entry */
> +#define ICMP_EXT_MULT_IFS	4	/* Multiple Interfaces Satisfy Query */
> +
> +/* Constants for EXT_ECHO (PROBE) */
> +#define EXT_ECHOREPLY_ACTIVE	(1 << 2)/* active bit in reply message */
> +#define EXT_ECHOREPLY_IPV4	(1 << 1)/* ipv4 bit in reply message */
> +#define EXT_ECHOREPLY_IPV6	1	/* ipv6 bit in reply message */
> +#define EXT_ECHO_CTYPE_NAME	1
> +#define EXT_ECHO_CTYPE_INDEX	2
> +#define EXT_ECHO_CTYPE_ADDR	3
> +#define ICMP_AFI_IP		1	/* Address Family Identifier for ipv4 */
> +#define ICMP_AFI_IP6		2	/* Address Family Identifier for ipv6 */

I'm a bit surprised how the EXT_* macros step outside of the general
ICMP namespace here.

And the ICMP_EXT_* macros seem to be for different PDU fields even
though they share a common prefix (ICMP_EXT_).

Thanks,
Florian