public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Lukasz Majewski <lukma@denx.de>
Cc: Joseph Myers <joseph@codesourcery.com>,
	 Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	 Florian Weimer <fweimer@redhat.com>,
	GNU C Library <libc-alpha@sourceware.org>,
	 Florian Weimer <fw@deneb.enyo.de>,
	 Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v2] tst: Provide test for sched_rr_get_interval
Date: Mon, 08 Feb 2021 11:15:23 +0100	[thread overview]
Message-ID: <87im72amro.fsf@igel.home> (raw)
In-Reply-To: <20210208094252.17086-1-lukma@denx.de> (Lukasz Majewski's message of "Mon, 8 Feb 2021 10:42:52 +0100")

On Feb 08 2021, Lukasz Majewski wrote:

> diff --git a/posix/tst-sched_rr_get_interval.c b/posix/tst-sched_rr_get_interval.c
> new file mode 100644
> index 0000000000..d632e03655
> --- /dev/null
> +++ b/posix/tst-sched_rr_get_interval.c
> @@ -0,0 +1,45 @@
> +/* Test for sched_rr_get_interval
> +   Copyright (C) 2021 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <https://www.gnu.org/licenses/>.  */
> +
> +#include <time.h>
> +#include <sched.h>
> +#include <support/check.h>
> +
> +static int
> +do_test (void)
> +{
> +  struct timespec ts[2] = { { -1, -1 }, { -1, -1 } };
> +  const struct sched_param param = {
> +    .sched_priority = sched_get_priority_max (SCHED_RR) - 10,
> +  };
> +  int result = sched_setscheduler (0, SCHED_RR, &param);
> +
> +  if (result != 0)
> +    FAIL_UNSUPPORTED ("*** sched_setscheduler error: %m\n");
> +
> +  TEST_COMPARE (sched_rr_get_internal (0, ts), 0);
> +
> +  /* Check if returned time values are correct.  */
> +  TEST_VERIFY_EXIT (ts[0].tv_sec < 0);
> +  TEST_VERIFY_EXIT (ts[0].tv_nsec < 0 || ts[0].tv_nsec >= 1000000000);
> +  TEST_VERIFY_EXIT (ts[1].tv_sec != -1 || ts[1].tv_nsec != -1);

There should be no need to exit immediately on failure.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

  reply	other threads:[~2021-02-08 10:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08  9:42 Lukasz Majewski
2021-02-08 10:15 ` Andreas Schwab [this message]
2021-02-08 14:45   ` Lukasz Majewski
2021-02-08 15:06     ` Andreas Schwab
2021-02-08 10:57 Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im72amro.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=fw@deneb.enyo.de \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=lukma@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).