From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id D68FB3857010 for ; Mon, 8 Feb 2021 10:15:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D68FB3857010 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=whitebox@nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DZ2320FMWz1qs0Z; Mon, 8 Feb 2021 11:15:26 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DZ2316fzKz1qqkw; Mon, 8 Feb 2021 11:15:25 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 0D7Ffdqo3dJT; Mon, 8 Feb 2021 11:15:24 +0100 (CET) X-Auth-Info: /S/zrMYWgWlgrquvZEcC+mFbsoaIUQlfFOkWDkCOUH8sHySTaO7QTRYT/9U/NthQ Received: from igel.home (ppp-46-244-175-90.dynamic.mnet-online.de [46.244.175.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 8 Feb 2021 11:15:24 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id B395C2C32B5; Mon, 8 Feb 2021 11:15:23 +0100 (CET) From: Andreas Schwab To: Lukasz Majewski Cc: Joseph Myers , Adhemerval Zanella , Florian Weimer , GNU C Library , Florian Weimer , Alistair Francis Subject: Re: [PATCH v2] tst: Provide test for sched_rr_get_interval References: <20210208094252.17086-1-lukma@denx.de> X-Yow: Hello, GORRY-O!! I'm a GENIUS from HARVARD!! Date: Mon, 08 Feb 2021 11:15:23 +0100 In-Reply-To: <20210208094252.17086-1-lukma@denx.de> (Lukasz Majewski's message of "Mon, 8 Feb 2021 10:42:52 +0100") Message-ID: <87im72amro.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2021 10:15:29 -0000 On Feb 08 2021, Lukasz Majewski wrote: > diff --git a/posix/tst-sched_rr_get_interval.c b/posix/tst-sched_rr_get_interval.c > new file mode 100644 > index 0000000000..d632e03655 > --- /dev/null > +++ b/posix/tst-sched_rr_get_interval.c > @@ -0,0 +1,45 @@ > +/* Test for sched_rr_get_interval > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > +#include > + > +static int > +do_test (void) > +{ > + struct timespec ts[2] = { { -1, -1 }, { -1, -1 } }; > + const struct sched_param param = { > + .sched_priority = sched_get_priority_max (SCHED_RR) - 10, > + }; > + int result = sched_setscheduler (0, SCHED_RR, ¶m); > + > + if (result != 0) > + FAIL_UNSUPPORTED ("*** sched_setscheduler error: %m\n"); > + > + TEST_COMPARE (sched_rr_get_internal (0, ts), 0); > + > + /* Check if returned time values are correct. */ > + TEST_VERIFY_EXIT (ts[0].tv_sec < 0); > + TEST_VERIFY_EXIT (ts[0].tv_nsec < 0 || ts[0].tv_nsec >= 1000000000); > + TEST_VERIFY_EXIT (ts[1].tv_sec != -1 || ts[1].tv_nsec != -1); There should be no need to exit immediately on failure. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."