From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>
Cc: Siddhesh Poyarekar <siddhesh@sourceware.org>
Subject: Re: [PATCH] Build libc-start with stack protector for SHARED
Date: Wed, 03 Feb 2021 10:32:34 +0100 [thread overview]
Message-ID: <87im79sdhp.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210203054219.1589041-1-siddhesh@sourceware.org> (Siddhesh Poyarekar via Libc-alpha's message of "Wed, 3 Feb 2021 11:12:19 +0530")
* Siddhesh Poyarekar via Libc-alpha:
> This does not change the emitted code since __libc_start_main does not
> return, but is important for formal flags compliance.
>
> This also cleans up the cosmetic inconsistency in the stack protector
> flags in csu, especially the incorrect value of STACK_PROTECTOR_LEVEL.
Would it be cleaner to split the shared and static __libc_start_main
implementations into different files? There isn't that much overlap
between the two.
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
next prev parent reply other threads:[~2021-02-03 9:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 5:42 Siddhesh Poyarekar
2021-02-03 9:32 ` Florian Weimer [this message]
2021-02-03 13:45 ` Siddhesh Poyarekar
2021-02-03 13:48 ` Florian Weimer
2021-02-03 14:35 ` Siddhesh Poyarekar
2021-02-03 14:37 ` Florian Weimer
2021-02-08 13:42 ` Nix
2021-02-08 14:21 ` Siddhesh Poyarekar
2021-02-08 15:58 ` Nix
2021-02-08 16:02 ` Siddhesh Poyarekar
2021-02-08 19:06 ` Nix
2021-02-11 14:35 ` [PING][PATCH] " Siddhesh Poyarekar
2021-02-11 19:25 ` [PATCH] " Adhemerval Zanella
2021-02-12 0:56 ` Siddhesh Poyarekar
2021-02-12 2:55 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im79sdhp.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).